Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
One reason our profile page look lame today is that there is no visual or semantic grouping around a profile 'category'. This one line patch fixes this.
Comment | File | Size | Author |
---|---|---|---|
#5 | profile_box.patch | 605 bytes | moshe weitzman |
profile.group.patch | 634 bytes | moshe weitzman | |
Comments
Comment #1
breyten CreditAttribution: breyten commentedelements are only allowed in forms though. But I agree that the grouping should be improved.
Comment #2
breyten CreditAttribution: breyten commentedI really meant fieldset elements. Sorry!
Comment #3
Bèr Kessels CreditAttribution: Bèr Kessels commentedIMO we should wait a little more with this, iuntill we have theme wrapper. I have code already to creatre a patch for the profiles which will use the theme_wrapper. It will also allow a bit better themeing og the profile pages.
You can already see the DOM and the possibilities of the theme here: http://84.244.1.246. That uses theme_wrapper , amongst others
Comment #4
moshe weitzman CreditAttribution: moshe weitzman commentedCome on Ber. You want to wait on a 1 line patch? Beware of introducing dependencies that aren't strictly necessary. This one line can be changed again later. No big deal.
Comment #5
moshe weitzman CreditAttribution: moshe weitzman commentedThis time using theme('box') since form_group() is not valid outside of a form (thanks breyten).
Comment #6
Dries CreditAttribution: Dries commentedCommitted to HEAD. Thanks.
Comment #7
(not verified) CreditAttribution: commented