One reason our profile page look lame today is that there is no visual or semantic grouping around a profile 'category'. This one line patch fixes this.

CommentFileSizeAuthor
#5 profile_box.patch605 bytesmoshe weitzman
profile.group.patch634 bytesmoshe weitzman

Comments

breyten’s picture

breyten commented

elements are only allowed in forms though. But I agree that the grouping should be improved.

breyten’s picture

breyten commented

I really meant fieldset elements. Sorry!

Bèr Kessels’s picture

Bèr Kessels commented

IMO we should wait a little more with this, iuntill we have theme wrapper. I have code already to creatre a patch for the profiles which will use the theme_wrapper. It will also allow a bit better themeing og the profile pages.
You can already see the DOM and the possibilities of the theme here: http://84.244.1.246. That uses theme_wrapper , amongst others

moshe weitzman’s picture

moshe weitzman commented

Come on Ber. You want to wait on a 1 line patch? Beware of introducing dependencies that aren't strictly necessary. This one line can be changed again later. No big deal.

moshe weitzman’s picture

moshe weitzman commented
StatusFileSize
new profile_box.patch605 bytes

This time using theme('box') since form_group() is not valid outside of a form (thanks breyten).

dries’s picture

dries commented

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented