Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
just curious. can't find any discussion of a possible port in the forum - would love to see it for drupal6!
Comment | File | Size | Author |
---|---|---|---|
#62 | nodereview-236442.patch | 117.82 KB | bigjim |
#53 | nodereview.zip | 21.66 KB | bomarmonk |
#25 | nodereview.patch | 60.21 KB | junedkazi |
#21 | nodereview-6.dev_.tar_.gz | 17.3 KB | junedkazi |
Comments
Comment #1
Fayna CreditAttribution: Fayna commentedI would also! It's a must-have!! :)
Comment #2
almafa CreditAttribution: almafa commentedi second this request :)
Comment #3
las0mbra CreditAttribution: las0mbra commentedI third this request :)
Comment #4
Crell CreditAttribution: Crell commentedThis module depends on both Views and Voting API. It cannot be ported to Drupal 6 until both of those have a stable release.
Comment #5
gumdrop CreditAttribution: gumdrop commentedIt's getting there ;-)
Comment #6
Flying Drupalist CreditAttribution: Flying Drupalist commentedYay, subscribing mate.
Comment #7
stuartgoff CreditAttribution: stuartgoff commentedme too!
Comment #8
drupaloSa CreditAttribution: drupaloSa commentedsubscribing...
Comment #9
stuartgoff CreditAttribution: stuartgoff commentedIs there a time frame for the D6 release?
Comment #10
Tebb CreditAttribution: Tebb commentedSubscribing.
Comment #11
zilla CreditAttribution: zilla commentedso views has been reasonably solid for a bit, just wondering if this port to d6 is still on the table~any insight appreciated.
Comment #12
Crell CreditAttribution: Crell commentedI am currently working at getting a new maintainer for this module, as I do not have anywhere near the time to give it the love it deserves. :-(
Comment #13
zilla CreditAttribution: zilla commentedthanks for the update - hopefully somebody will grab the torch!
Comment #14
chipway CreditAttribution: chipway commentedHi,
Any news about maintainer and port ?
Thanks
Comment #15
Crell CreditAttribution: Crell commentedbrenda003 has been added as a maintainer and given carte blanche to bug fix and upgrade the module. Brenda, help us! :-)
Comment #16
JubW CreditAttribution: JubW commentedYes update would be very helpful
Comment #17
Dave ReidSubscribing
Comment #18
Dominion CreditAttribution: Dominion commentedsubscribing.
This is exactly what I am looking for and I am really looking forward to the d6 version!
Comment #19
brenda003Sadly I've been horribly busy and haven't had a chance to work on this. I was hoping to get to it this coming week, but now kids are sick, yadda yadda. I did get contacted by another working on the upgrade, so hopefully we can combine any efforts and can have an update soon.
Comment #20
junedkazi CreditAttribution: junedkazi commentedhi Guys,
I have been working on this for the past 2 days and I have spoken to Brenda as well as she mentioned it in the previous comment . Hopefully we will have a copy of 6.x version by the coming weekend .
Thanks
Juned kazi
Comment #21
junedkazi CreditAttribution: junedkazi commentedHi ,
I think I finally made it . I have attached a tar file of the entire module .
Pls do review it and let me know .
Juned Kazi
Comment #22
junedkazi CreditAttribution: junedkazi commentedI will just change the status . The code needs review
Comment #23
Crell CreditAttribution: Crell commentedA tarball is not a patch. Please submit a proper patch against the 5.x-dev branch so that it can be reviewed. (The HEAD tag is long out of date, as I do not use HEAD for modules.) http://drupal.org/patch/create
Comment #24
junedkazi CreditAttribution: junedkazi commentedCrell
I attached a tar file because the original files were modified and some new files have been added like
1 - Moved the complete admin settings to nodereview.admin.inc
2 - Now views have 2 files nodereview.views.inc & nodereview.views_default.inc
3 - I moved all the theme functions to a theme file call nodereview.theme.inc
so that all the code is not cluttered in 1 or 2 file .
But still if you want it as a patch let me try . I will post it by tommorow .
Thanks
Juned Kazi
Comment #25
junedkazi CreditAttribution: junedkazi commentedI am attaching the patch for nodereview . I am very new to creating patches.
So Please excuse me if I have done something wrong . I tried this patch on my
local development box and it did work . So I am posting the patch for the
community to test . The patch has been created against 5.x-dev .
kindly provide feedback .
Thanks
Juned Kazi
Comment #26
chirale CreditAttribution: chirale commentedOn admin/content/nodereview checking content type and saving cause a:
warning: Invalid argument supplied for foreach() in /stor/www/mysite.com/sites/all/modules/nodereview/nodereview.admin.inc on line 216.
On line 216 I change:
to:
and error gone.
Since fivestar is not a required module, module_exists should be used.
Another interesting implementation can be converting the drop down weight assignment on admin screen to drag and drop, like blocks.
Comment #27
Crell CreditAttribution: Crell commentedLet's NOT add new features as part of the upgrade. That can happen after we have an initial release. Enough people are waiting on it that I'd rather do the minimum necessary for a 1.x release, then enhance from there.
Comment #28
junedkazi CreditAttribution: junedkazi commentedchirale
But this error should not have appeared .
The checkbox for the fivestar will be visible
only if the fivestar module is enabled . So the
question of the error while saying does not arise .
I will try and replicate this issue .
Thanks
Juned Kazi
Comment #29
chirale CreditAttribution: chirale commentedIt happened because
$form_values['fivestar']
if module is disabled is not declared, so the foreach on admin screen is applied to an undeclared variable. The error message appears after submittingadmin/content/nodereview
.@Crell: You are right, this is only a suggestion nice to see after the first release. :-)
Comment #30
ninjascience CreditAttribution: ninjascience commentedi've been trying for hours and I get get a the reviews_list block, added to my bottom content area, to show the current reviews on a node. I've enabled reviews for my node type ('Product' in my case). I've messed around with creating similar views to the product_list view provided. If I specify that the block version of the view show all reviews if the argument is not present, that works, but it's not what I want. I need to show the reviews for the current node.
I'm new to drupal but not new to PHP or web dev. I've been working on this for hours. This could very have nothing to do with this module, but if other users of the patch could at least report that they don't have a similar problem, then I could rule out the module as an issue.
I'm using the latest patch provided above.
Comment #31
brooho CreditAttribution: brooho commentedjunedkazi, thank you very much!!!!!!!
Comment #32
junedkazi CreditAttribution: junedkazi commentedbrooho : hope it worked for u fine .
And u don't need to say thank u . I have gained so much from this community
so I felt it is time to give something back as well .
Thanks
Juned Kazi
Comment #33
andypost+1
Comment #34
JordanMagnuson CreditAttribution: JordanMagnuson commentedOne more vote for this.
Comment #35
gearhead CreditAttribution: gearhead commentedSo what isthe status?
Is the module ported to D6?
I need it so I can upgrade www.burent.com
Comment #36
Flying Drupalist CreditAttribution: Flying Drupalist commentedComment #37
batje CreditAttribution: batje commentedsubscribe
@Crell or Brenda003: Could you check the patch in, so we can debug this .dev version more easily?
Comment #38
zdean CreditAttribution: zdean commentedThis would be a great module for D6 when it's wrapped up.
Thanks!!
Comment #39
zdean CreditAttribution: zdean commentedWe haven't heard from the maintainers in a couple of months...any timeline available for the D6 port? I would be willing to contribute to a chipin fund to get this rolling...
Comment #40
gausarts CreditAttribution: gausarts commentedsubscribe. thanks
Comment #41
gausarts CreditAttribution: gausarts commentedOOT:
Hi, gearhead,
sorry to let you know here, are you allowing anon people to create menus on your site, www.burent.com? Please correct me if I am wrong. Thanks
Comment #42
JubW CreditAttribution: JubW commentedIt would be AWESOME if we could use this for drupal 6
Comment #43
bomarmonk CreditAttribution: bomarmonk commentedTesting the module in #21 with changes made in #26. I'll report any problems here. Thanks for your work on this!
Comment #44
pijio CreditAttribution: pijio commented@bomarmonk - Very interested on how this turns out. Subscribing.
Comment #45
bomarmonk CreditAttribution: bomarmonk commentedThe module is working well without any errors so far in my drupal 6.9 install. I've reported one feature request to have custom labels work with the axis on the node review settings page.
Comment #46
bomarmonk CreditAttribution: bomarmonk commentedI should mention that the feature request I just mentioned has to do with Fivestar and how this module uses it. See http://drupal.org/node/370088
Comment #47
sege CreditAttribution: sege commentedWhere's the maintainers? Why don't we have a D6-branch? There's an almost ready to use patch and some nice comments on how to fix it. Just make one D6-branch for it now.. Grr. =)
Comment #48
drmori CreditAttribution: drmori commentedi second that....
Comment #49
zdean CreditAttribution: zdean commentedfor anyone who's interested, you can achieve the same thing using this combination of modules:
Nodereference CCK
Fivestar
Nodereferrer
Nodereferrer Create
I've almost finished putting it together for my site...once I've got the bugs worked out, I'll work on a tutorial. If you can't wait, the modules are not that difficult to work into a review solution.
Comment #50
drmori CreditAttribution: drmori commentedhey zdean, looking forward to that tutorial, thanks! lots of people will find it useful.
cheers!
Comment #51
kurzweil4 CreditAttribution: kurzweil4 commentedNodereferrer does not have a stable Drupal 5 release let alone a Drupal 6 branch.
Thanks for the info though.
Comment #52
zdean CreditAttribution: zdean commentedThey've got a patch that is adequate for making Nodereferrer Create work...
Comment #53
bomarmonk CreditAttribution: bomarmonk commentedHere's a patched version of Node Review. If it's working, why use two multiple modules to accomplish what you want to do, if you can do it with one? Maybe the maintainers can start the D6 branch/dev version when this is tested by a few more folks. Who knows.
Comment #54
kurzweil4 CreditAttribution: kurzweil4 commentedUPDATE: Looks like Crell made a few posts to this issue back in 11/2008, so perhaps not all hope is lost. I didn't notice these before.
==================
Bomarmonk,
Fantastic job making the patches to get version 6 out!
This project seems to be abandoned. What I think is that the community should take over. Here is a document on how to deal with abandoned projects:
http://drupal.org/node/251466
I think you should get your self added as a developer and/or take over and add your patches as a version 6 trunk. If you can do this, I would be more than happy to help you test.
You may already know about this, but in case you are not, here is a tool that can assist with converting modules to 6.x:
http://drupal.org/project/coder
Have you already run your version through this?
Kurzweil4
Comment #55
bomarmonk CreditAttribution: bomarmonk commentedActually, I just applied the patches already created in this thread and then zipped up the module for people to use. I would recommend that one of the people who actually created the patches should take over. We're probably better off with someone who actually did the coding.
Comment #56
bomarmonk CreditAttribution: bomarmonk commentedAlthough, in the absence of a real PHP developer, I could at least get something posted for the project; I would be willing to do that!
Comment #57
Crell CreditAttribution: Crell commentedHi folks.
Yeah, I've really dropped the ball on this module. Sorry. :-( My current plan is to try and find the time to make a D6 branch using one of the patches in this thread, then hand the module off to someone who will actually maintain it. I just need to block out an hour or two to get the D6 branch going. At this point I doubt it will happen before DrupalCon, as I am booked solid until then.
Again, sorry for the interminable delays.
Comment #58
kurzweil4 CreditAttribution: kurzweil4 commentedCrell,
Glad to see you are alive and kicking and still keeping track of the project!
If we could just get to a stable release for 6, I think that would go a long way.
Comment #59
junedkazi CreditAttribution: junedkazi commentedbomarmonk
I have really worked hard on it and I would like to maintain it or co-maintain it with some one.
I had written to Crell to add me as a co maintainer but I haven't heard from him till now.
I had also spoken to Brenda about it but she said u will have to speak to Crell as he still owns the
project. So I was back to square one.
Comment #60
kurzweil4 CreditAttribution: kurzweil4 commentedCrell is still alive and well, so we should be in good shape.
Comment #61
drmori CreditAttribution: drmori commentedzdean, any new on the tutorial you mentioned to use nodereferrer instead of nodereview?
it seems that all the modules you mentioned in your post are working.... looking forward to getting some tips!
Comment #62
bigjim CreditAttribution: bigjim commentedhere's a patch of bomarmonk's zip file from 53
Comment #63
zdean CreditAttribution: zdean commentedSorry. Not yet. I've run into a snag with this method...you can't limit each user to just 1 review of each item being reviewed.
Comment #64
highvoltage CreditAttribution: highvoltage commentedI thought new maintainers were already lined up... Did they have a change of plans and crell is back looking for somebody to hand the module over to?
Comment #65
Flying Drupalist CreditAttribution: Flying Drupalist commentedIs there a block for the add review link? So we can place it somewhere else other than a tab?
Thanks.
Comment #66
level09 CreditAttribution: level09 commentedhow about
Comment #67
gauravkumar87 CreditAttribution: gauravkumar87 commentedsubscribing...
Comment #68
junedkazi CreditAttribution: junedkazi commentedI have added a dev version for nodereview for D6.
So I am making this as fixed .
If you have any issues with the dev version create separate issues.