NodeReview Drupal 6 Port

zilla - March 19, 2008 - 20:03
Project:NodeReview
Version:HEAD
Component:Code
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed
Description

just curious. can't find any discussion of a possible port in the forum - would love to see it for drupal6!

#1

Fayna - April 2, 2008 - 01:55

I would also! It's a must-have!! :)

#2

almafa - April 7, 2008 - 23:45

i second this request :)

#3

las0mbra - April 10, 2008 - 20:08

I third this request :)

#4

Crell - April 10, 2008 - 20:25
Status:active» postponed

This module depends on both Views and Voting API. It cannot be ported to Drupal 6 until both of those have a stable release.

#5

gumdrop - June 29, 2008 - 14:56
Status:postponed» postponed (maintainer needs more info)

It's getting there ;-)

#6

Flying Drupalist - July 16, 2008 - 11:32

Yay, subscribing mate.

#7

stuartgoff - July 17, 2008 - 22:06

me too!

#8

drupaloSa - August 12, 2008 - 22:04

subscribing...

#9

stuartgoff - August 19, 2008 - 23:04

Is there a time frame for the D6 release?

#10

Dru-p - September 11, 2008 - 23:47

Subscribing.

#11

zilla - September 20, 2008 - 01:24

so views has been reasonably solid for a bit, just wondering if this port to d6 is still on the table~any insight appreciated.

#12

Crell - September 20, 2008 - 18:17

I am currently working at getting a new maintainer for this module, as I do not have anywhere near the time to give it the love it deserves. :-(

#13

zilla - September 22, 2008 - 15:26

thanks for the update - hopefully somebody will grab the torch!

#14

chipway-drupal - October 2, 2008 - 14:29

Hi,

Any news about maintainer and port ?

Thanks

#15

Crell - October 2, 2008 - 14:47

brenda003 has been added as a maintainer and given carte blanche to bug fix and upgrade the module. Brenda, help us! :-)

#16

JubW - October 23, 2008 - 03:15

Yes update would be very helpful

#17

Dave Reid - October 24, 2008 - 23:32

Subscribing

#18

Dominion - November 8, 2008 - 20:35

subscribing.

This is exactly what I am looking for and I am really looking forward to the d6 version!

#19

brenda003 - November 19, 2008 - 16:30

Sadly I've been horribly busy and haven't had a chance to work on this. I was hoping to get to it this coming week, but now kids are sick, yadda yadda. I did get contacted by another working on the upgrade, so hopefully we can combine any efforts and can have an update soon.

#20

junedkazi - November 22, 2008 - 12:25

hi Guys,

I have been working on this for the past 2 days and I have spoken to Brenda as well as she mentioned it in the previous comment . Hopefully we will have a copy of 6.x version by the coming weekend .

Thanks

Juned kazi

#21

junedkazi - November 26, 2008 - 12:08

Hi ,

I think I finally made it . I have attached a tar file of the entire module .
Pls do review it and let me know .

Juned Kazi

AttachmentSize
nodereview-6.dev_.tar_.gz 17.3 KB

#22

junedkazi - November 26, 2008 - 12:10
Status:postponed (maintainer needs more info)» needs review

I will just change the status . The code needs review

#23

Crell - November 26, 2008 - 15:56
Status:needs review» needs work

A tarball is not a patch. Please submit a proper patch against the 5.x-dev branch so that it can be reviewed. (The HEAD tag is long out of date, as I do not use HEAD for modules.) http://drupal.org/patch/create

#24

junedkazi - November 27, 2008 - 05:39

Crell

I attached a tar file because the original files were modified and some new files have been added like

1 - Moved the complete admin settings to nodereview.admin.inc
2 - Now views have 2 files nodereview.views.inc & nodereview.views_default.inc
3 - I moved all the theme functions to a theme file call nodereview.theme.inc

so that all the code is not cluttered in 1 or 2 file .
But still if you want it as a patch let me try . I will post it by tommorow .

Thanks

Juned Kazi

#25

junedkazi - November 28, 2008 - 07:44

I am attaching the patch for nodereview . I am very new to creating patches.
So Please excuse me if I have done something wrong . I tried this patch on my
local development box and it did work . So I am posting the patch for the
community to test . The patch has been created against 5.x-dev .
kindly provide feedback .

Thanks

Juned Kazi

AttachmentSize
nodereview.patch 60.21 KB

#26

chirale - November 29, 2008 - 13:01

On admin/content/nodereview checking content type and saving cause a:

warning: Invalid argument supplied for foreach() in /stor/www/mysite.com/sites/all/modules/nodereview/nodereview.admin.inc on line 216.

On line 216 I change:

<?php
 
foreach ($form_values['fivestar'] as $option => $value) {
   
variable_set('nodereview_fivestar_'. $option, $value);
  }
?>

to:

<?php
 
if(module_exists('fivestar')) {
    foreach (
$form_values['fivestar'] as $option => $value) {
   
variable_set('nodereview_fivestar_'. $option, $value);
    }
  }
?>

and error gone.

Since fivestar is not a required module, module_exists should be used.

Another interesting implementation can be converting the drop down weight assignment on admin screen to drag and drop, like blocks.

#27

Crell - November 30, 2008 - 01:50

Let's NOT add new features as part of the upgrade. That can happen after we have an initial release. Enough people are waiting on it that I'd rather do the minimum necessary for a 1.x release, then enhance from there.

#28

junedkazi - November 30, 2008 - 04:35

chirale

But this error should not have appeared .
The checkbox for the fivestar will be visible
only if the fivestar module is enabled . So the
question of the error while saying does not arise .
I will try and replicate this issue .

Thanks

Juned Kazi

#29

chirale - December 2, 2008 - 21:32

It happened because $form_values['fivestar'] if module is disabled is not declared, so the foreach on admin screen is applied to an undeclared variable. The error message appears after submitting admin/content/nodereview.

@Crell: You are right, this is only a suggestion nice to see after the first release. :-)

#30

ninjascience - December 5, 2008 - 22:03

i've been trying for hours and I get get a the reviews_list block, added to my bottom content area, to show the current reviews on a node. I've enabled reviews for my node type ('Product' in my case). I've messed around with creating similar views to the product_list view provided. If I specify that the block version of the view show all reviews if the argument is not present, that works, but it's not what I want. I need to show the reviews for the current node.

I'm new to drupal but not new to PHP or web dev. I've been working on this for hours. This could very have nothing to do with this module, but if other users of the patch could at least report that they don't have a similar problem, then I could rule out the module as an issue.

I'm using the latest patch provided above.

#31

brooho - December 8, 2008 - 11:53

junedkazi, thank you very much!!!!!!!

#32

junedkazi - December 9, 2008 - 04:31

brooho : hope it worked for u fine .
And u don't need to say thank u . I have gained so much from this community
so I felt it is time to give something back as well .

Thanks

Juned Kazi

#33

andypost - December 14, 2008 - 01:50

+1

#34

davidlerin - December 17, 2008 - 15:02

One more vote for this.

#35

gearhead - December 24, 2008 - 16:41

So what isthe status?
Is the module ported to D6?

I need it so I can upgrade www.burent.com

#36

Flying Drupalist - December 24, 2008 - 16:45
Title:is this coming to drupal6?» NodeReview Drupal 6 Port

#37

batje - January 6, 2009 - 15:11

subscribe

@Crell or Brenda003: Could you check the patch in, so we can debug this .dev version more easily?

#38

zdean - January 8, 2009 - 02:11

This would be a great module for D6 when it's wrapped up.

Thanks!!

#39

zdean - January 11, 2009 - 07:02

We haven't heard from the maintainers in a couple of months...any timeline available for the D6 port? I would be willing to contribute to a chipin fund to get this rolling...

#40

gausarts - January 30, 2009 - 05:36

subscribe. thanks

#41

gausarts - January 30, 2009 - 05:41

OOT:
Hi, gearhead,

sorry to let you know here, are you allowing anon people to create menus on your site, www.burent.com? Please correct me if I am wrong. Thanks

#42

JubW - February 3, 2009 - 06:15

It would be AWESOME if we could use this for drupal 6

#43

bomarmonk - February 6, 2009 - 00:43

Testing the module in #21 with changes made in #26. I'll report any problems here. Thanks for your work on this!

#44

pijio - February 8, 2009 - 17:11

@bomarmonk - Very interested on how this turns out. Subscribing.

#45

bomarmonk - February 8, 2009 - 17:54

The module is working well without any errors so far in my drupal 6.9 install. I've reported one feature request to have custom labels work with the axis on the node review settings page.

#46

bomarmonk - February 8, 2009 - 17:55

I should mention that the feature request I just mentioned has to do with Fivestar and how this module uses it. See http://drupal.org/node/370088

#47

sege - February 16, 2009 - 21:24

Where's the maintainers? Why don't we have a D6-branch? There's an almost ready to use patch and some nice comments on how to fix it. Just make one D6-branch for it now.. Grr. =)

#48

drmori - February 17, 2009 - 04:03

i second that....

#49

zdean - February 20, 2009 - 00:09

for anyone who's interested, you can achieve the same thing using this combination of modules:

Nodereference CCK
Fivestar
Nodereferrer
Nodereferrer Create

I've almost finished putting it together for my site...once I've got the bugs worked out, I'll work on a tutorial. If you can't wait, the modules are not that difficult to work into a review solution.

#50

drmori - February 21, 2009 - 08:37

hey zdean, looking forward to that tutorial, thanks! lots of people will find it useful.

cheers!

#51

kurzweil4 - February 22, 2009 - 23:52

Nodereferrer does not have a stable Drupal 5 release let alone a Drupal 6 branch.

Thanks for the info though.

#52

zdean - February 24, 2009 - 21:15

They've got a patch that is adequate for making Nodereferrer Create work...

#53

bomarmonk - February 25, 2009 - 03:25

Here's a patched version of Node Review. If it's working, why use two multiple modules to accomplish what you want to do, if you can do it with one? Maybe the maintainers can start the D6 branch/dev version when this is tested by a few more folks. Who knows.

AttachmentSize
nodereview.zip 21.66 KB

#54

kurzweil4 - February 25, 2009 - 04:53

UPDATE: Looks like Crell made a few posts to this issue back in 11/2008, so perhaps not all hope is lost. I didn't notice these before.

==================

Bomarmonk,

Fantastic job making the patches to get version 6 out!

This project seems to be abandoned. What I think is that the community should take over. Here is a document on how to deal with abandoned projects:

http://drupal.org/node/251466

I think you should get your self added as a developer and/or take over and add your patches as a version 6 trunk. If you can do this, I would be more than happy to help you test.

You may already know about this, but in case you are not, here is a tool that can assist with converting modules to 6.x:

http://drupal.org/project/coder

Have you already run your version through this?

Kurzweil4

#55

bomarmonk - February 25, 2009 - 04:35

Actually, I just applied the patches already created in this thread and then zipped up the module for people to use. I would recommend that one of the people who actually created the patches should take over. We're probably better off with someone who actually did the coding.

#56

bomarmonk - February 25, 2009 - 05:56

Although, in the absence of a real PHP developer, I could at least get something posted for the project; I would be willing to do that!

#57

Crell - February 25, 2009 - 16:27

Hi folks.

Yeah, I've really dropped the ball on this module. Sorry. :-( My current plan is to try and find the time to make a D6 branch using one of the patches in this thread, then hand the module off to someone who will actually maintain it. I just need to block out an hour or two to get the D6 branch going. At this point I doubt it will happen before DrupalCon, as I am booked solid until then.

Again, sorry for the interminable delays.

#58

kurzweil4 - February 25, 2009 - 18:50

Crell,

Glad to see you are alive and kicking and still keeping track of the project!

If we could just get to a stable release for 6, I think that would go a long way.

#59

junedkazi - February 26, 2009 - 05:08

bomarmonk

I have really worked hard on it and I would like to maintain it or co-maintain it with some one.
I had written to Crell to add me as a co maintainer but I haven't heard from him till now.
I had also spoken to Brenda about it but she said u will have to speak to Crell as he still owns the
project. So I was back to square one.

#60

kurzweil4 - February 26, 2009 - 13:52

Crell is still alive and well, so we should be in good shape.

#61

drmori - March 4, 2009 - 16:58

zdean, any new on the tutorial you mentioned to use nodereferrer instead of nodereview?
it seems that all the modules you mentioned in your post are working.... looking forward to getting some tips!

#62

jalama - March 14, 2009 - 00:18

here's a patch of bomarmonk's zip file from 53

AttachmentSize
nodereview-236442.patch 117.82 KB

#63

zdean - March 17, 2009 - 16:39

Sorry. Not yet. I've run into a snag with this method...you can't limit each user to just 1 review of each item being reviewed.

#64

highvoltage - March 28, 2009 - 19:42

I thought new maintainers were already lined up... Did they have a change of plans and crell is back looking for somebody to hand the module over to?

#65

Flying Drupalist - March 29, 2009 - 17:53

Is there a block for the add review link? So we can place it somewhere else other than a tab?

Thanks.

#66

level09 - April 3, 2009 - 15:53

how about

<?php
echo l('Add a review','node/' .$node->nid .'/addreview');
?>

#67

gauravkumar87 - April 21, 2009 - 10:49

subscribing...

#68

junedkazi - May 16, 2009 - 16:41
Status:needs work» fixed

I have added a dev version for nodereview for D6.
So I am making this as fixed .
If you have any issues with the dev version create separate issues.

#69

System Message - May 30, 2009 - 16:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.