Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I get plenty of "page not found" warnings when I look at the admin page, but I have no way to fix them. The pages (rightfully) no longer exist, so I'd simply like to stop links pointing there. If the referering page was part of the message, that would be far more helpful.
Comment | File | Size | Author |
---|---|---|---|
#13 | watchdog-referer-storage-final.patch | 3.07 KB | Stefan Nagtegaal |
#9 | watchdog-referrer-cvs.patch | 3.14 KB | ahoeben |
#7 | watchdog-referer.patch | 3.14 KB | Stefan Nagtegaal |
#3 | watchdog-referrer.patch | 1.6 KB | ahoeben |
Comments
Comment #1
ahoeben CreditAttribution: ahoeben commentedReferer / referrer loggin would be usefull for a more than just page not found warnings. I'ld say include them where available.
Comment #2
ahoeben CreditAttribution: ahoeben commentedThis requires minor changes in bootstrap.inc (watchdog() function), the watchdog module, as well as an alteration to the watchdog table. I'll try to make a patch
Comment #3
ahoeben CreditAttribution: ahoeben commentedHere's the patch against 4.6.2.
First, you need to execute this SQL statement to alter the watchdog table:
ALTER TABLE `watchdog` ADD COLUMN `referer` varchar (128) NOT NULL
Next, the patch includes two one-line changes, one each for includes/bootstrap.inc and modules/watchdog.module
(you may have to split up the patch file and run them one by one or manually)
Comment #4
drumm+1 for this functionality, but it needs to be a patch against Drupal CVS.
Comment #5
kbahey CreditAttribution: kbahey commented+1 on functionality too.
Comment #6
Bèr Kessels CreditAttribution: Bèr Kessels commented+1 on the idea.
But this really needs a patch for update.php and database.* marking this "active" untill that is in place.
Comment #7
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedOkay I updated the patch to apply against HEAD.
I also updated the update.inc to reflect the changes..
Please update the patch or apply.. I do not have time to keep this patch up-to-date.
Comment #8
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedStatus -> 'Patch', Version -> 'CVS'..
I updated the patch to work with current HEAD.
Please apply or pdate yourself. I do not have time to keep this patch up-to-date.. Sorry
Comment #9
ahoeben CreditAttribution: ahoeben commentedNew patch against CVS. Includes stefan's patch for updates.inc (thanks) and adds database.mysql and database.pgsql
Comment #10
Gábor Hojtsy+1, I was just looking for this data on 404 messages, and found nothing useable on my 4.6 site, obviously searching for referer data.
Comment #11
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedI noticed this while making the patch myself, but we use 'referer' in the code and database layer, but in the table header we use 'referrer'.. Notice the 'r' against 'rr'..
I'm not a native English speaking person, but I would like to see some consistency between this.. Or 'referrer' or 'referer', not both please...
For the patch it's functionality +1!
Comment #12
Junyor CreditAttribution: Junyor commentedStefan: The header is actually called 'referer', so in the code it makes sense.
Comment #13
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedOkay, updated patch to use 'referer' instead of 'referrer'...
Ready to be applied... :-)
Comment #14
ahoeben CreditAttribution: ahoeben commentedActually, the HTTP header calls it 'referer', but 'referrer' is better english (AFAIK, but I am not a native english speaker either). That's why I used referer internally (since it's a reference to the HTTP header), but referrer in the presentation (better english).
You Say Potato, I Say Potato
Comment #15
Junyor CreditAttribution: Junyor commentedRight. I didn't mean to imply that anything needed to change. In the code it makes sense to use 'referer' while the text would make sense as either 'referer' or 'referrer'. Sorry for your trouble, Stefan.
Comment #16
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedWell, patch #10 use 'Referrer' and #13 uses 'Referer'.. Let the Drupal Gods dicide which one to apply to core... :-)
Comment #17
Steven CreditAttribution: Steven commentedCommitted to HEAD.
Comment #18
(not verified) CreditAttribution: commentedComment #19
(not verified) CreditAttribution: commentedComment #20
(not verified) CreditAttribution: commentedComment #21
(not verified) CreditAttribution: commentedComment #22
(not verified) CreditAttribution: commented