Two issues that I run into every time I use the Issues pages (using Firefox):

1) When doing a simple issues search and changing the status to "active,fixed,patch,duplicate,postponed,won't fix,by design,closed", it pushes that entire search nav to the right and underneath the right-hand blocks. This could be fixed by giving the status select box a definitive CSS width. Screenshot attached.

2) Why can't the issues search do a GET instead of a POST? After doing a search, then going to the details page of an issue, and using the back button, I receive a Firefox dialog box warning me that the POST data may be expired. Going back and forth in the issues pages would be a lot easier if the search was not a POST request.

Thanks!

Comments

benthere’s picture

2) Why can't the issues search do a GET instead of a POST? After doing a search, then going to the details page of an issue, and using the back button, I receive a Firefox dialog box warning me that the POST data may be expired. Going back and forth in the issues pages would be a lot easier if the search was not a POST request.

I just came by to post the same issue and found this. POST should only be used as a form action when you are modifying/submitting data, where submitting it twice causes problems. GET should be used when you are filtering data, or when you're not actually changing anything in a DB, just presentation.

Should be a simple fix of "POST" -> "GET" in one spot.

samo’s picture

Status: Active » Needs review
StatusFileSize
new861 bytes

Patch (against CVS) attached to change the two search interfaces in the project module to use GET instead of POST. Note that I do not have a working local version of project available (haven't been able to get it fully up and running yet).

dww’s picture

Version: x.y.z » 5.x-1.x-dev
Status: Needs review » Needs work

(1) from the original post has been long-since fixed.

Patch from comment #2 no longer applies. Not sure if this is still worth doing, but I'll hold off on "won't fix" until I get a 2nd opinion.

aclight’s picture

Title: Project->Issues Usability » Advanced search should use method=GET

Changing title to be more descriptive.

I myself have often found it annoying that the POST warning box pops up when I hit the back button in this situation.

I don't have much knowledge of POST vs GET form methods, but it does look like an easy fix.

For my reference, the forum API reference mentioning #method is at http://api.drupal.org/api/5/file/developer/topics/forms_api_reference.ht...

On the other hand, see the last comment on http://drupal.org/node/106693 for a potential alternative way to do this

pwolanin’s picture

This is probably not as easy as it sounds, and should be accompanied by a Forms API conversion

aclight’s picture

Status: Needs work » Postponed

I believe that this will be something we get for free when #76726: Refactor project module to use Views [meta issue] happens. I'm postponing until then.

dww’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Component: User interface » Views integration
Assigned: Unassigned » dww
Status: Postponed » Fixed

Indeed, we got this for free when I ported all the issue queues to views2.

dww’s picture

Project: Project » Project issue tracking

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.