Port of SpreadFirefox to Drupal 6.x

when i am back home next week, i will test your work and commit it if it is ok.

Thanks for the work!

So is this good to go? I'd love to use it!

I tried it for a few minutes on a drupal 6 website. It appears to work fine :)

Any chance of an "official" release? Even a dev release would make me feel a bit more comfortable with using it on a production site.

Mostly looks good. Couple of issues for me:
- In the right sidebar, the light green background for blocks is gone and the block titles are not bolded
- I often get the main content pushed down below the bottom of the left side bar (FF3 example attached)

Looks like there's still lots of 'sidebar-left' and 'sidebar-right' in the css. We could either change them all to 'right' and 'left' like the regions in the template, or we could just go back to calling the regions what they were before and defining them properly in the .info file.

Personally, I'd prefer the latter, since I think in the end, that would be a smaller change from the 5.x version. I'll try to take a crack at that tonight.

Well, it seems to work. For you 5.x to 6.x upgraders, try just adding this .info file (remove the .txt extension, I couldn't upload it with the .info ext). It fixes my side-bar style problems, but not the main content problem.

To be clear don't add my .info file to the zip package in the original post. No changes to the files you already have for 5.x. Just add the .info file to what you have.

OK, one more problem with the original package. The footer message doesn't print. This is fixed in #8 above.

I'm marking it 'needs work' because I still have the css clear issues in #6 and I haven't considered the $language to $language->language change referenced in the orignial.

Any help would be appreciated.

OK, found the reference for changing $language to $language->language so here's a patch to be applied to the 5.x version of page.tpl.php.

So to test:

1. download latest 5.x theme and install.
2. download the .info file in #8 (remove the .txt from the end) and put in the spreadfirefox directory
3. apply the page.tpl.php patch (or make the edit manually)

Still need a fix for the css clear issue. could it be a result of the way I only defined the default style.css in the .info file? All the other css files seem to be getting applied also, but I don't pretend to understand how that works.

Well, figuring that the firefox problem in the would be easier to solve, I started poking around the page i took the firefox screenshot from. It comes from a Drupal 6 install with spreadfirefox theme installed per #11 above. That particular page is a calendar view built with Date-6.x-2.0-rc1, Calendar-6.x-2.0-rc1, and Views-6.x-2.0-rc1. The huge white-space is a div (

.clear-block {
  display: inline-block;
}

/* Hides from IE-mac \*/
* html .clear-block {
  height: 1%;
}
.clear-block {
  display: block;
}
/* End hide from IE-mac */

.date-nav {
  width:100%;
  display:inline-block;    <=== This one
}

Since my last change was not actually a change to this them, I guessI'll mark this 'needs review'. Hopefully someone besides me is still using this theme. Anybody else tried this out?

Bueller? ... Beuller? ...

To upgrade your SFF theme, did you follow the steps in #11? If you would, then we'd be debugging the same code. Are you using Date & Calendar modules?

Thanks.

Might there be a dev release of this theme soon for 6.x?

@pengi,
I've tried to contact the theme's maintainer, but haven't gotten a reply. Could you follow the steps in #11 above and give me some feedback on how it works for you? If you're not comfortable applying the patch, I could upload the new page.tpl file later this evening.

If I can get some other review, maybe we can get this put out at least as a 6.x-dev release.

sorry for the silence from my site. I have just upgraded one of my sites to drupal 6.x and going to test the changes of skor. As soon as possible i will upgrade the theme on drupal.org.

MM

That'd be great...Skor I've not used patches so I'll wait for the release. Thanks

@Mad Maks, no problem and no need to apologize. I'd appreciate any help you could give. I'm not much of a css guru, though I'm recognizing the need to learn it.

@pengi, here's the page.tpl.php file with the patch applied. You'll have to remove the .txt ending (drupal.org added that for some reason) and then you can just put it in the themes/spreadfirefox directory with the rest of the files. Would appreciate any testing help you could give. Any chance you're using the calendar and date modules?

And for anyone else who's interested, I went ahead and deployed my updates to this site: http://news.stpaulcatholic.org

please test http://ftp.drupal.org/files/projects/spreadfirefox-6.x-1.x-dev.tar.gz

i don't see the problem #12 with the latest version of the mention modules

Thanks!
I'm planning an upgrade this weekend. I'll let you know how it works.