Removing the href link from images that are in nodes

but the link in the content node is being created by whatever means you create that node... are you using tinymce? fckedit? image attach? etc.... How do you edit the content nodes and insert the images into them?

Yeah, I've been playing around with this too. There's several places the code appears. I've been working with the one in the theme_image_attach_body function (the very end of the image attach module). There's no HREF because the l(...) function is the theme function that actually creates the hyperlink (which is why you don't see the HREF in the module itself.

Simply removing that function leaves:

image_display($image, $img_size) which doesn't show the picture. That's where I stopped. I think what you need to do is change that into a simple IMG tag which would change that line to:

$output .= '<img src="'. image_display($image, $img_size). '" />';

I just haven't had a chance to try it yet to verify.

Also, hacking a module constantly gets to be very old--- you may want to file a feature request with in the module's issue queue to have the hyperlink optional.

Post back if it works.....

I ended up using the img_assist module with the Image module and I am finding it much better and easier than img_attach. Here you can easily edit that link setting as you add the image.

In Drupal 6:

If you don't want to hack the module directly (and most probably lose your changes when you update it), you can also override the theme_image_attach_body function by having the same function in your theme's template.php and replace 'theme' in the function name with your theme's name. For example, for a theme called 'drop' you would add the following to your template.php to completely remove the image links:

function drop_image_attach_body($node) {
  $img_size = variable_get('image_attach_size_body_'. $node->type, IMAGE_THUMBNAIL);

  if ($img_size != IMAGE_ATTACH_HIDDEN) {
    drupal_add_css(drupal_get_path('module', 'image_attach') .'/image_attach.css');

    $image = node_load($node->iid);
    if (!node_access('view', $image)) {
      // If the image is restricted, don't show it as an attachment.
      return NULL;
    }
    $info = image_get_info(file_create_path($image->images[$img_size]));

    $output = '<div style="width: '. $info['width'] .'px" class="image-attach-body">';
    $output .= image_display($image, $img_size);
    $output .= '</div>'."\n";

    return $output;
  }
}

Thanks a lot men, you've just ended 1 hour of changing the module code. Thanks again.

Yes, exactly. You can do a solution similar to the above one by defining your own theme, but an easier, global fix is to comment out line 657 in the image_attach.module file, i.e.

// $link_destination = $options['link'];

that means none of your attached images will be linked to anything, which is what I usually want (or if I want them to link to something, I do that using a different tool).