Closed (fixed)
Project:
Diff
Version:
5.x-2.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Mar 2008 at 20:32 UTC
Updated:
5 Apr 2008 at 14:02 UTC
Jump to comment: Most recent file
Diffs in the new 2.0 release are formatted in four columns, each 25% of the available width. This is happening because the COL elements aren't being output, so the CSS setting the column widths isn't being applied to the diff table.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | contrib-5.diff.cols_.junyor.patch | 1.1 KB | junyor |
Comments
Comment #1
junyor commentedIt looks like this is only a problem when you preview changes on node edits.
Comment #2
moshe weitzman commentedThanks Junyor. If you come up with a patch, I'll apply it.
Comment #3
junyor commentedI'll see what I can come up with. Does it make sense to call theme_diff_table() in diff_node_form_add_changes() instead of theme_table()? I'm not sure if there's a reason you didn't use theme_diff_table() there.
Comment #4
junyor commentedAssuming that's all that's needed, here's a patch that seems to do the trick.
Comment #5
moshe weitzman commentedcommitted to 5. D6 handles this properly already.
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.