Download & Extend

Clean up user-related functions

Project:SimpleTest
Component:Code
Category:feature request
Priority:normal
Assigned:beeradb
Status:closed (fixed)

Issue Summary

Here you go, does exactly what the title says... I know this may conflict with webchicks recent t() work, so let me know if it needs a re-roll

AttachmentSizeStatusTest resultOperations
drupalLoginUser_to_drupalLogin.patch43.27 KBIgnored: Check issue status.NoneNone

Comments

#1

Status:active» needs work

Yea, this needs to be rerolled.

#2

re-rolled. I also changed it a bit so drupalLogin now uses drupalLogout instead of $this->drupalGet('logout') to log a user out if they are already logged in

AttachmentSizeStatusTest resultOperations
rename_drupalLoginUser.patch35.17 KBIgnored: Check issue status.NoneNone

#3

Status:needs work» needs review

forgot to set status

#4

Title:add drupalLogout function and rename drupalLoginUser to drupalLogin» Clean up user-related functions

I'm going to re-purpose this issue to clean up not only drupalLogin/drupalLogout but also drupalCreateUser and drupalCreateRole.

#5

Status:needs review» needs work

This seems to still need rerolling.

#6

Status:needs work» needs review

Ok, let's try this. I tried to run all the simpletests before posting this, but it's taking forever. :P I guess we can clean up anything that got messed.

I reformatted the drupalCreateUser and drupalCreateRole functions a bit to make them a bit easier to understand. I also made drupalCreateRole private, since nothing but drupalCreateUser should be calling that function.

AttachmentSizeStatusTest resultOperations
simpletest-cleanup-user-237369-6.patch49.24 KBIgnored: Check issue status.NoneNone

#7

Status:needs review» fixed

Committed.

Great work.

#8

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here