Here you go, does exactly what the title says... I know this may conflict with webchicks recent t() work, so let me know if it needs a re-roll

CommentFileSizeAuthor
#6 simpletest-cleanup-user-237369-6.patch49.24 KBwebchick
#2 rename_drupalLoginUser.patch35.17 KBbeeradb
drupalLoginUser_to_drupalLogin.patch43.27 KBbeeradb

Comments

boombatower’s picture

boombatower commented
Status: Active » Needs work

Yea, this needs to be rerolled.

beeradb’s picture

beeradb commented
StatusFileSize
new rename_drupalLoginUser.patch35.17 KB

re-rolled. I also changed it a bit so drupalLogin now uses drupalLogout instead of $this->drupalGet('logout') to log a user out if they are already logged in

beeradb’s picture

beeradb commented
Status: Needs work » Needs review

forgot to set status

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: add drupalLogout function and rename drupalLoginUser to drupalLogin » Clean up user-related functions

I'm going to re-purpose this issue to clean up not only drupalLogin/drupalLogout but also drupalCreateUser and drupalCreateRole.

boombatower’s picture

boombatower commented
Status: Needs review » Needs work

This seems to still need rerolling.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new simpletest-cleanup-user-237369-6.patch49.24 KB

Ok, let's try this. I tried to run all the simpletests before posting this, but it's taking forever. :P I guess we can clean up anything that got messed.

I reformatted the drupalCreateUser and drupalCreateRole functions a bit to make them a bit easier to understand. I also made drupalCreateRole private, since nothing but drupalCreateUser should be calling that function.

boombatower’s picture

boombatower commented
Status: Needs review » Fixed

Committed.

Great work.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.