Add description to update notifications

Ralf Stamm - March 22, 2008 - 05:42
Project:Update Notifications Disable
Version:6.x-1.0
Component:User interface
Category:feature request
Priority:normal
Assigned:Unassigned
Status:patch (code needs review)
Description

I think it's useful to add a description to update notifications on page status report that update notifications is disabled by this module.

function update_requirements($phase) {
  if ($phase == 'runtime') {
    $requirements['update status'] = array(
      'severity' => REQUIREMENT_WARNING,
      'description' => t('Disabled by module <em>Update Notification Disable</em>.'),
    );
  }
  return $requirements;
}

AttachmentSize
update-notification-disable-description.png11.64 KB

#1

webchick - March 24, 2008 - 15:43

Darn! I wanted this to be the only project with NO issues in its issue queue. :D

Anyway, this makes sense. Only thing is, I wonder if there's a way to make "Enabled" "Disabled" since it's confusing to say "Enabled" and then in the description that it's "disabled" :P

This also might not be possible. Could you investigate and report back one way or the other? Then I can commit this patch.

#2

Ralf Stamm - April 18, 2008 - 08:51

There is no way to make "Enabled" "Disabled".

module_invoke_all() uses array_merge_recursive() which append new values but not overwrite the original one.

The values 'severity' and 'description' are not set yet, so we can use it.

May be a better description won't confuse the user so much.

 
 

Drupal is a registered trademark of Dries Buytaert.