I think it's useful to add a description to update notifications on page status report that update notifications is disabled by this module.


function update_requirements($phase) {
  if ($phase == 'runtime') {
    $requirements['update status'] = array(
      'severity' => REQUIREMENT_WARNING,
      'description' => t('Disabled by module <em>Update Notification Disable</em>.'),
    );
  }
  return $requirements;
}
CommentFileSizeAuthor
update-notification-disable-description.png11.64 KBrstamm

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Darn! I wanted this to be the only project with NO issues in its issue queue. :D

Anyway, this makes sense. Only thing is, I wonder if there's a way to make "Enabled" "Disabled" since it's confusing to say "Enabled" and then in the description that it's "disabled" :P

This also might not be possible. Could you investigate and report back one way or the other? Then I can commit this patch.

rstamm’s picture

rstamm commented

There is no way to make "Enabled" "Disabled".

module_invoke_all() uses array_merge_recursive() which append new values but not overwrite the original one.

The values 'severity' and 'description' are not set yet, so we can use it.

May be a better description won't confuse the user so much.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Closed (won't fix)

I thought the whole point of this module was to turn off the warnings on that page. What good is replacing:

"Update notifications are not enabled. It is highly recommended that you enable the update status module from the module administration page in order to stay up-to-date on new releases. For more information please read the Update status handbook page."

with:

"Disabled by the Update Notification Disable module"

?