port to d6?

The module has been updated to Drupal 5 so now it should be fairly easy to upgrade it to Drupal 6 using the coder module and the conversion guide. I'm not currently planning to do this myself in the near future though.

I would also love an update to Drupal 6. I unfortunately can not do it on my own.

subscribing! A D6 port would be lovely (but unfortunately I'm not up to the job)

Here is a patch of the my current progress porting Flickrstickr to 6.

Please ignore the first directory when applying, i.e. using -p

$ cd flickrstickr
$ patch -p1 < /path/to/halfwayport6.patch

Apologies in advance from departing slightly from the following things:
1. dependency on Image (I don't see why a Flickr interface needs to save images to disk, but maybe I'm missing something...)
2. not diffing from the HEAD

My patch is diffed from the 5.x-1.x-dev package on 2008-07-11.

Here's what a patched module should be able to do:
- installable in 6
- admin/settings/flickrstickr lets you save the API
- "Flickr image insert" fieldset appears in the node creation page
- able to search Flickr and select photos
- selected photos appear in the "Body" with special Flickrstickr markup

Known issues:
- after installing a bunch of warnings appear in admin/build/modules

Important things to note:
- Flickrstickr filter is yet to be tested

I'm planning to create a dependency between Flickrstickr and Flickr module, because some of the codebase seems to overlap. Also Flickr module already has a Flickr filter. Anyway, let me know your thoughts.

Subscribing. Good luck guys, keep up the good work.

Created a new patch -- this can be applied to CVS HEAD. Fixed the warnings appearing on admin/build/modules.

TODO:
- Test with the image module, and with the Flickrstickr filter enabled.
- Update flickrstickr.js to use jQuery

If Flickrstickr works with Image without any problems, then I'll post up the final patch and we should have a patched module that is ready for community testing. However, if any problems run really deep, I'll need somebody's help.

Thanks for the patch!

Keep them coming.
The issues I can report now:
- In Firefox 3, the carousel is pretty stretches so wide horizontally that it is not usable unless I resized my browser window to at least 1200 pixels. Or you can use the horizontal scrollbar to pan the page, but this kind of defies the purpose of the carousel.
- For some reasons, the code is able to find some users (a few), and fail for find other users. Or it finds one user, but if you change the user field, it will fail finding that user (even if it was able to find it in the past); as if once a user was found, there was no way to change.
- It doesn't seem you can pull images only by tag (i.e., not specify any user)
- The image do not show up in Preview mode
- Saving the node failed (I have the proper write access though):
* Creating local copy of flickr picture
files/images/3581_3284168180_cfab6c48c4
* Story Test has been updated.
* The selected file could not be copied, because no file by that name exists. Please check that you supplied the correct filename.
* Unable to create image

Thanks for the feedback. Would you be able to say if these issues were present in the 5.x version? I would like to concentrate only on the issues my patch has created. We can create other tickes to isolate each issue. In any case I greatly appreciate your help in testing.

[deleted double post]

I understand where you are going here, sadly, I don't have a 5.x.
Based on some screenshots I had bookmarked flickrstickr a while ago (I'm a Flickr fan), but this is the first time I use it.
Now if we want to isolate some problems we better "align" our distribution.
Which Drupal major/minor release are you using? Which version of the Image module? Which browser? On what Operating System?

From what I reported, I would just make sure you can save a node and the Flickr images are showing up, then iron out the rest. Is that the case?
I'm on a Win32 box, can you double-check that you didn't miss a hard-coded Unix path?
Is flickrstckr saving the Flickr image locally then passing it to the Image module, or is the Image module doing all of this?

Thanks

Environment: Drupal 6.8, Image 6.x-1.0-alpha4, Firefox 3.0.6 on Leopard.

This patch saves a node and the Flickr image shows up. I've only tested with one image. I don't think previews work.

The only change to the patch was to correct where the module was writing its locally-stored Flickr files. It was trying to write it to files/ in the Drupal root. But, I use a multisite setup with each site directory having its own files/. The fix was pretty trivial - prefix the paths with `file_directory_path()`.

Because you're curious: FlickrStickr saves the image locally using `flickstickr_saveimages`, which calls a `flickrstickr_file_put_contents`. After the file is saved locally, FlickrStickr creates a node from a `stdObject` and links it to the create image file, then saves the node. Image module is used to build the derivatives; i.e., thumbnail, small, etc...

On a bit of a holiday at the moment, but I'll still be checking mail and I could use some feedback on this patch, anyway.

Setting version to HEAD, because that's where the patch should be applied.

Anyone available to review this patch?

I believe the patch converts the 5.x module to 6.x without losing any functionality. This result is a legal 6.x module; I don't think any work needs to be further done for the 6.x migration. But we'll only know after testing.

On a separate but related issue, programmers would benefit if some refactoring happened for this module so that it uses 6.x conventions particularly in the FAPI and Javascript. We could create these tasks after this patch is tested and committed to HEAD.

Subscribing.

+1 for porting to Drupal 6. Subscribing.

There are many more options to integrate Drupal with Flickr. Flickrstickr has been abandoned.