| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | update.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
At dww's request I'm opening a new issue to continue a discussion from #235425: HEAD release always considered Not Supported during cron.
This started out with Event module having a 5.x-2.x-dev release node which wasn't displayed on its front page. The snapshot release node has since been enabled (see #237483: Please publish the 2.x-dev releases on the front page), so we've lost the test case, but the issue remains as an edge case.
Having installed the current 5.x-2.x-dev snapshot release, I got this in Update Status (D5):
Event 5.x-2.x-dev (2008-Mar-11) Not supported
Recommended version: 5.x-2.x-dev (2008-Mar-11)
As dww conceded, "it's a little weird for it to print out a 'recommended' version in this case." IMHO, when the 'recommended version' would be the same as the one already installed, the second line shouldn't be there at all.
When there's a newer version available, it's still a bit odd to display 'recommended' and 'not supported' at the same time. Something like "Latest version" might be better to understand. Maybe the string can at least be fixed for D7.
Finally, as dww explained in the original thread, Update Status complains about the most scary warning on the status report page, which in this case is "Not supported". Setting Event to "Ignore 5.x-2.x-dev" fixes that, but at the same time it silences any notifications about 5.x-2.x-dev updates. It would be nice to have something in between...
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| 235425.3.png | 6.18 KB | Ignored: Check issue status. | None | None |
Comments
#1
#239324: Misreporting backup module update status? marked duplicate. Yes, this is annoying. It'd be nice to fix it in a way that doesn't break the string freeze, but I'm not sure if that's possible.
#2
Well, the recommended version is included since development versions could change often, right? And it is unsupported due to it being a developer version. But yeah, having the recommended version string there is quite confusing for those who obviously don't care about all the tech stuff behind.
#3
I'm sorry, I don't follow your explanation.
I had the version installed that was "Recommended" for me to download again.
Apparently, this is triggered by not having any release (-dev or otherwise) on the front page: the installed version is rejected as "unsupported" and anything that happens to be around is suggested as a replacement, even if it's what's already installed...
#4
Right, to clarify, here's what's going on:
A newer branch might not be marked as "supported" yet by the project maintainer. This has nothing to do with it being -dev or official -- it's just a setting on the project pages themselves. However, if someone downloads one of these unsupported versions from a newer branch, and it's weird for update.module to be telling anyone that the latest release from the unsupported branch is "recommended". As suggested in the original post, something like "Latest version" would be a lot better in this case than "Recommended version"...
Note: this is related to #208766: Latest release from maintainer's recommended branch called "Also available", not "Recommended" but it's a different edge case and should be handled in a separate issue, so this is still "active".
#5
This happens in D7 now, so I'm marking this for D8 for backporting. (Is that the correct workflow.)
To restate:
If you have an unsupported branch in your site, Update Status will mark the same unsupported branch as the "Recommended Version".
Example in attached screenshot: Detail of Available Updates, focusing on my own project, Square Grid theme:
Note in this example that 7.x-3.x-dev is flagged as "not supported" (correct) and offers the same branch, an updated snapshot, as the "Recommended version" (erroneous). However, for this project only 7.x-2.x and 7.x-1.x are supported branches. 7.x-3.x exists, but is currently broken and not supported. (In release management for the project on d.o, the 3.x branch is not checked as supported, nor visible.)
Expected behavior: A stable release (and possibly a -dev release) of a supported branch would be displayed as "recommended". If a link to the unsupported branch is offered at all, it should be marked as "Updated development snapshot of current unsupported branch" or something like that.