Add language filter to Drupal core

Thanks, this is most welcome, strange that not many else has reflected this huge problem,

These patches work. However, by applying them I'm sure some other feature request like 'Seach in all languages' will pop up, which btw makes a lot of sense, as searches are text based thus search terms have some language by themselves.

So about the search form, I think we should try to add a language field to the search form that defaults to current language and that would be it.

Feedback/suggestions welcomed, and patches more welcomed yet :-)

Thanks a lot for the node patch! I applied it and it seems to work fine.
I wonder how a bug like that (duplicate stories on the front page!) was allowed to pass through testing of drupal version 6.

Are these patches working with D6.3 and is it now a part of the beta release of this module ?

i have this patch installed in 6.3 and seems ok so far
in fact i just grabbed my patched files from 6.2 and overwrote the 6.3 original files - probably not recommended but seems to work ok.
I only did that cos i hate the drupal's patching method, which is not exactly simple.

Yes, but what can you do when the Drupal core development team doesn't solve things that is important fast enough even with contributions from the community, a lot of patches are waiting to get added and never does.

Yes, this should be done as a new 'language' search operand, but this is very difficult to do.

The issue is that it's not enough to add checkboxes to the search form and then read them in and turn that into hook_db_rewrite_sql() clauses. Full core search support requires that all search criteria be treated as operands that can be contained in the url of the search. So in this case we would need e.g. "language:en,fr" in the search string.

See #69595: Node search operands should be extsnsible and moved out of node.module for some of the problems involved in trying to add custom search operands to Drupal's core search. If we want to keep operand support, the approaches open to us are (in the order of what seems best):

* Solve #69595: Node search operands should be extsnsible and moved out of node.module
* Hard-code a new "language" operand into core's search, alongside the existing hard-coded operands
* Write an API contrib module for handling custom search operands
* Add a ton of code to i18n to handle custom search operands.

If we limit ourselves to what would amount to a partially broken search, we could just:

* Add checkboxes and check for the $_REQUEST and rewrite search sql without adding operand support.

Merging the thread in #316147: Multilingual Search for Multilanguage site
We should also add some content selection options specific for search if we find the way to add some fields to the search form.

+

subscribing

Please provide unified patches, http://drupal.org/patch/create

Again, we are not including core patches as part of i18n module. So this is still open till we find a module-only approach that needs no core patching.

But this patch does not change the search form, or the resulting listing?
The idea is to allow search for items in the current language, or all languages?

In search form I had filter the duplicates in other languages when $url contents "node/" in module/search/search-result.tpl.php
It works for me.

<?php
 if(!ereg('node/',$url))
 {
?>
<dt class="title">
  <a href="<?php print $url; ?>"><?php print $title; ?></a>
</dt>
<dd>
  <?php if ($snippet) : ?>
    <p class="search-snippet"><?php print $snippet; ?></p>
  <?php endif; ?>
  <?php if ($info) : ?>
  <p class="search-info"><?php print $info; ?></p>
  <?php endif; ?>
</dd>
<?
 }
?>

@Andrew Answer:

That is nice, but could you use unified diffs? (diff -u)

They are much easier to read ...

Drupal 6 and 7 are feature frozen. This can only be addressed in D8.

I wonder if these patches could be integrated into a distribution like Pressflow (https://launchpad.net/pressflow), where they actually make core changes and ensure these work across drupal updates.?

Repy to #34 Posted by Andrew Answer on December 7, 2010 at 8:06pm

I made a better fix for this issue.
No core hack.. just a module.
http://drupal.org/node/995500

Super!! I spent too long time to find a non-patch solution to this, before giving this a try. Thank you, much appreciated.
One problem: this removes 'active' class from the language list.

Any such patch would be for Drupal 8.

Sorry but egon.ojamaa's module ( http://drupal.org/node/995500 ) works very fine in Drupal 6.19 but break translation system in 6.20.

Waiting for an update!

Fixed my module.. happy using
http://drupal.org/node/995500

Hi,

This absolute is a needs work.

Sorry @ Andrew Answer: While I see your need for those changes the approach taken to patch core is wrong, because all that you do can be done in a custom module.

Every query you changed has db_rewrite_sql and that for a reason.

So that modules can alter the behavior. So if you want to change all those queries, please use code like this:

  function mymodule_db_rewrite_sql($query, $primary_table, $primary_field, $args) {
    global $language;

    switch ($primary_field) {
      case 'nid':
              // this query deals with node objects
              $return = array();
              if ($primary_table != 'n') {
                $return['join'] = "LEFT JOIN {node} n ON $primary_table.nid = n.nid";
              }
              // FORCE SITE LANGUAGE
              $return['where'] = 'n.language="' . $language->language .  '"';
              return $return;
        break;
    }
  }

This essentially does the same as your code, but without patching.

As for the language switcher:

@Egon: I looked at your module and while your approach is working, you don't need to add a new language switcher block.

You can just implement (to change the language switcher):

function mymodule_translation_link_alter(&$links, $path) {

  global $language;

  foreach($links as $lang => $link) {
    if ($language->language == $lang) {
      // Andrew solution:
      unset($links[$lang]["href"]);
      // Egon solution
      unset($links[$lang]);
    }
  }
}

This can be written even shorter as:

function mymodule_translation_link_alter(&$links, $path) {

  global $language;

  if (isset($links[$language->language]) {
    // Andrew solution:
    unset($links[$language->language]["href"]);

     // Egon solution
     unset($links[$language->language]);
  }
}

I have not yet understood the problem with the tnid - though. So I leave you one item for patching now :-).

I hope this helps solve these issues without having to patch core.

Best Wishes,

Fabian

Duplicate issue at #211831: Multilanguage dependent listings are not supported at all.

...coming from #316147: Multilingual Search for Multilanguage site which was closed as a duplicate of this one here.

Can we please have an updated issue summary with status and available patches/solutions for drupal 6, 7 & 8? I am looking for a solution to D7 multilingual site search. Anything available for testing?

blog.module.patch queued for re-testing.

Are these dupes???:

#1335832: The Drupal core "Who's new" block in a multilingual site always displays the users' real names in the site's default language.
#1331724: All translations of forum topics are displayed - no matter what language the site is switched to.

In Drupal 7 there isn't hook_db_rewrite_sql() any more. But you can use hook_query_alter().

Example (needs review):

/**
 * Implements hook_query_alter().
 */
function hook_query_alter(QueryAlterableInterface $query) {
  global $language;

  // Rewrite the sql query to exclude languages.
  if ($query->hasTag('node_access') && $query->hasTag('pager')) {
    $tables = $query->getTables();
    foreach ($tables as $table) {
      if ($table['table'] == 'search_index') {
        $query->condition('n.language', $language->language);
      }
    }
  }
}

I think this is outdated. I have been testing multilingual functionality on Drupal 9 and Drupal 10 for some time for the Bug Smash Initiative. I haven't experienced the problem in the Issue Summary.