Database code not postgresql compatible

znikke - March 23, 2008 - 12:01
Project:Node breadcrumb
Version:5.x-1.0-rc1
Component:Code
Category:bug report
Priority:normal
Assigned:edhel
Status:closed
Description

The database code in node_breadcrumb is full of mysqlisms, which makes the module not work using postgresql.

This patch replaces the mysql-specific stuff with code that should work on both mysql and postgres.

The only feature that got lost in the process is the index for the key table, the index syntax seems very different between postgres and mysql. I'm sure there is a standard way of adding indexes in drupal if it's really needed.

I completely dropped the specification of a default charset, if the DB is created correctly it shouldn't be needed if I have understood things correctly.

In any case, this patch makes the thing work using postgres 8.2 and drupal 5.1 on Ubuntu Gutsy.

AttachmentSize
node_breadcrumb-5.x-1.0-rc1-postgrescompat.patch2.09 KB

#1

edhel - April 15, 2008 - 16:56
Assigned to:Anonymous» edhel
Status:needs review» closed

fixed in 5.x-2.0-beta1

#2

edhel - April 15, 2008 - 16:58
Status:closed» fixed

#3

edhel - April 15, 2008 - 17:21
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.