Porting to drupal 6

sounds good, i'll give it a go in the near future, any other votes for this?

awesome!

I'm using this for a project on Drupal 6, so I've ported the module, and I thought I'd share the code; it's attached as "action_email_role_d6-plain.patch"

I also added a bit of code to restrict sending emails depending on the node type; D6 triggers are pretty simplistic out of the box and only address "node created" rather than something like "blog node created". This is attached as "action_email_role_d6-type_restrictions.patch"

Thanks for the patches! which revision did you patch from? i'm getting errors against current HEAD

dgtlmoon@nine:~/workspace/drupal.org-cvs/contributions/modules/action_email_role$ cat action_email_role_d6-plain.patch|patch -p1
patching file action_email_role.info
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file action_email_role.info.rej
patching file action_email_role.module
Hunk #1 FAILED at 35.
Hunk #2 FAILED at 85.
Hunk #3 FAILED at 101.
Hunk #4 FAILED at 113.
4 out of 4 hunks FAILED -- saving rejects to file action_email_role.module.rej

ah, sorry, I didn't patch against HEAD--I was using the DRUPAL-5--2 branch for some reason. I'd be happy to make it work against HEAD, but I might not get to it for a week or two...

@dgtimoon:

I just went to compare my code to HEAD, and HEAD doesn't have a working version of the code; I could produce a patch for it but it would basically consist of "replace everything in HEAD with xyz". If you want to use my work, I suggest just applying my patches to the DRUPAL-5--2 branch.

And actually, I found a bug in the -type_restrictions patch, so I'm attaching fresh versions of both patches.

heya bec, thanks for the patch - i dont have enough production sites to test this on, do you want CVS/project access so you can manage the release of 6.x?

Is the latest patch + 5.2 branch download will work in Drupal 6. And how do I apply the patch exactly? I try to use patch utility that comes with OS-X but doesn't work. Thanks.

@dgtlmoon -- sure, if you give me CVS access I'll be happy to work on the D6 version of this module.

oh, and arnoldc: I'll roll a dev release for Drupal 6 when I get CVS access. For the time being, there is a howto on applying patches here: http://drupal.org/node/60108

You are correct when you say that the latest patch in this thread + the 5.2 branch download will work in Drupal 6.

heya bec, you should have access now

I've created a Drupal 6 branch and rolled a beta release.

Thank you so much. I am eager to try it out!