Closed (fixed)
Project:
Text Size
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Mar 2008 at 05:36 UTC
Updated:
15 Feb 2009 at 22:50 UTC
Jump to comment: Most recent
Comments
Comment #1
CZ commentedThis is not a bug. It is a feature request. The modul have to be JavaScript indipendend.
Comment #2
Anonymous (not verified) commentedI'd second that as a feature request.
I suppose the workaround is to only publish the block on the homepage and that way the users won't really be redirected away from what they're looking at.
Otherwise - nice module. Really easy to use.
Cheers,
Comment #3
markj commentedAdding this feature would be great as many users find the current behavior counterintuitive.
Comment #4
silurius commentedSubscribing because I agree that this feature is probably a requirement in my case.
Comment #5
jonahan commentedYeah this functionality seems wrong. If you click to enlarge the text, you get redirected to the front page. You then have to click 'back' to see what you wanted to enlarge.
This is not intuitive and can throw users off.
Awesome module otherwise!
Comment #6
jonahan commentedThe following code will have the page redirect to itself:
Put it in the textsize.module file, in the function theme_textsize_html3() function. I put it right after:
$path_textsize = drupal_get_path('module', 'textsize');I noticed that the textsize module doesn't affect the size of content that is styled in pixels, so I had to set many things to use 'em' instead.
Comment #7
scottrigbyHi jonahan,
This does seem to work when adding into the module code itself...
But wouldn't it be better to override this using a theme function?
I tried to do that in my template.php (using a zen subtheme), and added the code there.
Unfortunately so far have not been able to get that to work this way... Any advice?
Thanks in advance! :)
Scott
Comment #8
banglogic commentedI tried this code on a site I am developing. It works when I am logged in but not when logged out... Perhaps something to do with caching?
Either way, I'm turning Text Size off for now until this can be worked out... Great module otherwise!
Comment #9
juanbond commentedI recently applied this modification to my site and it was working fine. Last week my site was compromised by a hacker though and I believe this modification may have been responsible for making the site vulnerable to a Cross-Site Scripting attack (xss). When it is active along with the search module, if a user inputs code such as <SCRIPT>malicious code</SCRIPT> into the search box, the full bracketed <SCRIPT> tags show in the source code. I'm new to XSS attacks so I may be wrong, but wanted to bring it up for someone with more experience in this area to check out.
Comment #10
CZ commentedThank you jonahan,
But
drupal_get_path_alias($_GET['q']);is not for "disabled clean urls". The next version (Text Size Beta 2) have no rederict to homepage and works for anonymus user!Comment #11
KingMoore commentedChristian Zwahlen,
Great module. Why don't you release your beta 2 on your drupal project page on drupal.org? That would be very helpful to everyone.
Comment #12
CZ commentedFixed in the 6.x-1.0 release.