Closed (fixed)
Project:
Drupal core
Component:
profile.module
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
28 May 2005 at 16:41 UTC
Updated:
5 Oct 2005 at 22:00 UTC
Jump to comment: Most recent file
line 63 seems wrong:
$result = db_query('SELECT name, title, type, visibility FROM {profile_fields} WHERE visibility = %d ORDER BY weight', PROFILE_PUBLIC, PROFILE_PUBLIC_LISTING);
PROFILE PUBLIC_LISTING should have an "S" at the end; also there is only one variable substitution in the above query. I believe it should be:
$result = db_query('SELECT name, title, type, visibility FROM {profile_fields} WHERE visibility = %d OR visibility = %d ORDER BY weight', PROFILE_PUBLIC,PROFILE_PUBLIC_LISTINGS);
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | profile_view_query_1.patch | 1.31 KB | nedjo |
| #3 | profile_view_query_0.patch | 1.31 KB | robin monks |
| #2 | profile_view_query.patch | 1.11 KB | robin monks |
Comments
Comment #1
samo commentedthis is still active in HEAD and is a very easy fix.
anyone?
Comment #2
robin monks commentedCorrects issue.
Tested to WORK on HEAD.
Robin
Comment #3
robin monks commentedAlso fixes someone else spelling mistake futher down (thanks to Malthus for noticing this).
Robin
Comment #4
nedjoThanks for catching these issues (they're from my previous patch). There should be a space after the comma (
PROFILE_PUBLIC, PROFILE_PUBLIC_LISTINGS), which I've added to the patch.Comment #5
robin monks commentedComment #6
dries commentedCommitted alternative solution.
Comment #7
(not verified) commentedComment #8
(not verified) commentedComment #9
(not verified) commentedComment #10
(not verified) commentedComment #11
(not verified) commented