line 63 seems wrong:

$result = db_query('SELECT name, title, type, visibility FROM {profile_fields} WHERE visibility = %d ORDER BY weight', PROFILE_PUBLIC, PROFILE_PUBLIC_LISTING);

PROFILE PUBLIC_LISTING should have an "S" at the end; also there is only one variable substitution in the above query. I believe it should be:

$result = db_query('SELECT name, title, type, visibility FROM {profile_fields} WHERE visibility = %d OR visibility = %d ORDER BY weight', PROFILE_PUBLIC,PROFILE_PUBLIC_LISTINGS);

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

samo’s picture

Version: 4.6.0 »

this is still active in HEAD and is a very easy fix.

anyone?

Robin Monks’s picture

Assigned: Unassigned » Robin Monks
Status: Active » Needs review
FileSize
1.11 KB

Corrects issue.

Tested to WORK on HEAD.

Robin

Robin Monks’s picture

FileSize
1.31 KB

Also fixes someone else spelling mistake futher down (thanks to Malthus for noticing this).

Robin

nedjo’s picture

FileSize
1.31 KB

Thanks for catching these issues (they're from my previous patch). There should be a space after the comma (PROFILE_PUBLIC, PROFILE_PUBLIC_LISTINGS), which I've added to the patch.

Robin Monks’s picture

Status: Needs review » Reviewed & tested by the community
Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed alternative solution.

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Status: Fixed » Closed (fixed)