Devel themer module compatible?

ardarvin - March 24, 2008 - 19:19
Project:Artists C01
Version:6.x-1.1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

In trying to learn more about theming I've installed the devel themer module. However artistC01 gives a:

"Fatal error: Call to a member function getName() on a non-object ... devel_themer.module on line 339"

when trying to view the theme (outside of the admin area).

According to Moshe who wrote the devel module, "yeah, themer does not use classes."

I don't suppose it would be an easy fix to allow artistC01 to be compatible with the devel module?

#1

JThan - May 6, 2008 - 23:25

Subscribe

#2

ztyx - May 25, 2008 - 07:31

Hi ardarvin,

I tried to reproduce the error by enabling ArtistsC01, Devel, 'Devel node access' and 'Theme developer' but could not. My versions are:
ArtistsC01: 6.x-1.1
Devel*: 6.x-1.8

,,,so on my computer ArtistsC01 seems to be fully compatible with Devel as far as I can see.

What versions do you have? Are you positive that your problem goes away when you disable the Devel module?

I have been able to reproduce the error with:

ArtistsC01: 6.x-1.1
Devel*: 6.x-1.8

One needs to leave the administration pages to reproduce it.

EDIT: This is probably related to ArtistsC01 as claimed here: http://drupal.org/node/237056
EDIT #2: Reading the issue referred to above, I managed to reproduce the error.

#3

ztyx - May 26, 2008 - 00:49
Status:active» needs review

The error was due to using the wrong declaration of artistsC01_feed_icon(...) as it needed to conform to theme_feed_icon($url,$title). Changing artistsC01_feed_icon($url) to artistsC01_feed_icon($url, $title) did the trick.

I am attaching a patch that fixes this issue and also incorporates the title into the <a href=...></a>.

AttachmentSize
template.php.diff 770 bytes

#4

ztyx - May 26, 2008 - 00:49
Category:support request» bug report

#5

ztyx - May 26, 2008 - 01:45

...if it makes anyone happier I have also proposed a patch to improve this error message as this error might happen to other themers as well and is a mess to debug.

#6

cha0s - August 28, 2008 - 20:57

[EDIT] Sorry, I posted too soon, another patch was developed that had the same functionality as mine. :)

 
 

Drupal is a registered trademark of Dries Buytaert.