As multilingual content and language fields are already in core, I think this is missing from the node fields

It's my first try with this version of views so please review.

(The patch is against views HEAD)

CommentFileSizeAuthor
views_language.patch2.7 KBjose reyero

Comments

merlinofchaos’s picture

merlinofchaos commented

Question: Do we really have to check for the 'translation' module specifically? It's a core field, I feel uncomfortable even making that check. I don't see any other code that's actually specific to that, and it prevents other modules from utilizing the fields in some manner.

Shouldn't there also be a filter option for "user's current language"?

Otherwise, this is looking like an excellent start. A couple of the function comments show cut & paste issues though =)

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed. An option for "User's current language" can come later.

merlinofchaos’s picture

merlinofchaos commented

There's definitely some issues with what I committed, so we'll have to work on them. In particular, I think we're not dealing properly with default languages; i.e, what if the 'language' field is not filled?

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

df412’s picture

df412 commented

can anyone tell me how to install this patch?

merlinofchaos’s picture

merlinofchaos commented

This was committed months ago; you don't need to install this patch.