.description text same color as body background

curtis - March 25, 2008 - 00:05
Project:I Feel Dirty
Version:6.x-1.0
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:reviewed & tested by the community
Description

The .description class defines the text color as #fff (white), which is the same color as the main body background. Redefining it to "inherit" or "#000" makes it visible.

#1

illogic-al - March 31, 2008 - 00:04

Can't reproduce. The .description refers to the site slogan which appears under the site name. For the IFeelDirty theme the background image is red so white text is fine. If changed to inherit or black then it looks out of place with the site name (and ugly).

#2

screamatme - April 24, 2008 - 01:28

I can reproduce this problem on the admin side of the theme and the forums category descriptions.

#3

frankf - April 24, 2008 - 16:27

Same here. The "description" text for a forum shows as white on very light grey, barely visible.

Also, Administer, Modules, Description same problem.

Love the theme, but I will have to find the best way to override the white text in .description for those, and maybe other, uses.

Looks like setting .description color to gray works all locations tested.

#4

curtis - May 8, 2008 - 19:31

It looks fine in the header -- as others have mentioned, it does not contrast properly in other areas where it is used.

Thanks,
Curtis.

#5

dalin - May 31, 2008 - 05:58

The problem being that the class 'description' is commonly used by Drupal (in the input format section of a node add form for example). The div used for the site slogan should maybe be re-classed as 'site-slogan'

                  <h1><a href="<?php print $front_page; ?>"><?php print $site_name; ?></a></h1>
                  <div class="description"><?php print $site_slogan ?></div>

becomes
                  <h1><a href="<?php print $front_page; ?>"><?php print $site_name; ?></a></h1>
                  <div class="site-slogan"><?php print $site_slogan ?></div>

and the css adjusted too:

.description {
  color: #fff;
  font-size: 12px;
}

becomes
.site-slogan {
  color: #fff;
  font-size: 12px;
}

#6

kaerast - December 5, 2008 - 13:16
Status:active» needs review

Attached is a patch for the above fix. It renames the description div to site-slogan, meaning that the site slogan in the header is still white whereas other locations that use the description class are left untouched.

AttachmentSize
ifeeldirtydescriptionfix.patch 951 bytes

#7

mennonot - May 9, 2009 - 16:19
Status:needs review» reviewed & tested by the community

Thanks for the patch, kaerast. I installed it and it fixed the problem for me.

Can we get this patch committed? Its a reasonably big headache for anyone who plans to administer a site with the Ifeeldirty theme and doesn't like having to highlight all the description text in order to read it.

 
 

Drupal is a registered trademark of Dries Buytaert.