Allowing submitters to edit their own scoops.

sanoju - March 25, 2008 - 03:58
Project:Drigg
Version:5.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:sicjoy
Status:closed
Description

The topic moved from http://drupal.org/node/232638.

I wish we could allow users to edit their own submitted stories. Since this feature involves a risk for spamming as described in the above post, the admin should be able to choose whether or not to enable this feature. It would be great to have the ability to specify the number of days the users can edit their contents after they submit, and whether the module should allow editing of PROMOTED stories or not.

#1

sicjoy - April 2, 2008 - 17:46
Assigned to:Anonymous» sicjoy

accepting assignment

#2

sicjoy - April 2, 2008 - 20:37
Status:active» needs review

Could someone check this patch. This one was pretty simple, but I thought I'd follow procedure.

AttachmentSize
drigg.module.patch 984 bytes

#3

sicjoy - April 4, 2008 - 23:54
Status:needs review» fixed

#4

drupalina - April 7, 2008 - 05:52
Status:fixed» postponed (maintainer needs more info)

Hi,
I noticed that in the drigg 23 there is a new option:
How many hours entries are able to be edited by submitters (set to 0 for indefinite)
cool...
I think this is a very good solution.

Thank you sicjoy!

But I wonder if you plan to implement a feature that disables "edit own scoop" for specified roles once it has been promoted to the front page? (as described in the original post above) I wonder if it is planned for the future developments??? I think this, plus the already developed max-hours feature, would be a more robust option policy-wise.

#5

mercmobily - April 7, 2008 - 07:04

Hi,

By seeing the patch, I noticed that it adds the permission:

"edit own drigg stories"

this means that you will be able to give this particular permission only to specific users. So, the two options (the time limitation and the role) will work together.

Bye,

Merc.

#6

drupalina - April 7, 2008 - 16:13

yes, but that's not what I asked.

I asked if there are plans to develop an option whereby (in addition to this new feature) admins can tick an option in Roles Access Controls "Disable Edit Own Drigg Story after promotion to front page"

#7

mercmobily - April 7, 2008 - 18:12

Hi,

Sicjoy, I think this would be very nice.
IS there any chance if you updating this patch?

Merc.

#8

sicjoy - April 9, 2008 - 01:20
Version:5.x-1.20» 5.x-1.x-dev
Status:postponed (maintainer needs more info)» needs review

OK - I added another permission: edit own promoted drigg story. If this is not ticked, the user will not be able to edit their stories once they have become promoted.

--sicjoy

AttachmentSize
drigg-anti-abuse-238372-2.patch 1.11 KB

#9

drupalina - April 9, 2008 - 12:36

Hi sicjoy,

I don't know how to test patches :(
But if you include this in the dev version, I can test it immediately and report back.

Thanks a bunch!

#10

mercmobily - April 9, 2008 - 12:45

Hi,

Watch out, because it takes 24 hours for the devel snapshot to actually go live...

Merc.

#11

sicjoy - April 9, 2008 - 19:54
Version:5.x-1.x-dev» 5.x-2.x-dev
Status:needs review» fixed

This patch has been incorporated into Drigg 2.

#12

mercmobily - April 10, 2008 - 02:10

Hi,

Sicjoy, I applied this to the DRUPAL-5--1 BRANCH.
I did change it slightly though...

    // Actual permission is given in two cases: either the story is not
        // promoted...
        if (!$node->promote){
          return TRUE;
        }
        // ...or the story is promoted and the user has the ability to
        // edit promoted stories!
        if ($node->promote && user_access('edit own promoted drigg stories')) {
          return TRUE;
        }

Have a look at the committed code.

Bye!

Merc.

#13

mercmobily - April 10, 2008 - 09:33
Status:fixed» closed

#14

drupalina - April 10, 2008 - 19:58
Status:closed» needs work

I've upgraded to the latest dev version (10 April) to test it. There is no option "edit own promoted drigg story" in the Access controls, or anywhere that I can find.

Has this really been committed? Where?

#15

mercmobily - April 11, 2008 - 02:44
Status:needs work» closed

Hi,

It is committed to the latest development version. However, development versions are only created once a day.

The new development version is a _major_ release. It will be out very soon - the most important thing is to check that the upgrade works.

Bye,

Nerc,

#16

sanoju - April 14, 2008 - 05:08

Hi,

Thank you for the great work.
I installed 5.x-1.x-dev to http://mountfujiguide.com, and confirmed that we cannot edit promoted stories unless the "edit own promoted drigg story" permission is given.

Drigg is such a wonderful tool. Thank you!

#17

mercmobily - April 14, 2008 - 11:55

Hi Sanjou,

I don't suppose you could drop me an email?

The address is "merc" followed by "mobily1" and then finally ".com"

Bye!

Merc.

 
 

Drupal is a registered trademark of Dries Buytaert.