Download & Extend

String "The" is being mistaken as an abbreviation for "Thessalonians"

Project:Scripture Filter
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

I'm running Drupal 4.7 and every once in a while I get a false match on a string that gets treated as a bible reference. Is there a way to tell Scripture Filter to ignore a block of text? Thanks in advance

Comments

#1

Priority:normal» minor
Assigned to:Anonymous» andrewspringman
Status:active» closed (fixed)

I figured out a way: Insert a blank comment.

For example, the string "The 2008" will make a false match. To prevent it, use "The 2008" instead.

OK, that didn't work. Let's try that again....

To prevent it, use "The<!-- --> 2008" instead.

#2

Title:Can I make it ignore a reference?» Overly broad matching
Version:4.7.x-1.1» master
Component:User interface» Code
Category:support request» bug report
Priority:minor» normal
Assigned to:andrewspringman» Anonymous
Status:closed (fixed)» active

Yep, that'll work -- anything that breaks up the scripture reference will keep it from matching.

I'm going to reopen this and make it a bug report, though - if it's matching "The 2008" as a scripture reference, that's too broad.

#3

We are having the same problem. We have a site that refers to "the 12 Steps" and it picks up "the 12" as a bible reference. we are using drupal 5. thanks!

#4

Version:master» 6.x-1.x-dev

Moving this to D6 version just to get a little more specific......

I'm seeing this same behavior with text of "The 2:7". You'll notice that all of these issues are starting with "The ...". Unless I'm forgetting something, 'The' isn't an abbreviation for any book, is it? If not, maybe the module could make a specific exception since this is going to be a broad issue for lots of folks.

Thoughts?

#5

Just jumping in to say we have this issue too (D6.19). It seems that the module thinks "The" is an abbreviation for 1 Thessalonians, since it tries to link to that book. If, for the books of 1 and 2 Thessalonians, the matching could be more restrictive, that would help. I don't think it's standard practice for those two books to use three-letter abbreviations. I've always seen them as "1 Thess" and "2 Thess".

I know you may not want to get too restrictive, but this situation is definitely too broad.

Sorry I'm not a coder so I can't offer a patch. Hopefully someone can.

#6

Title:Overly broad matching» String "The" is being mistaken as an abbreviation for "Thessalonians"
Version:6.x-1.x-dev» 7.x-1.x-dev

I have reproduced this. Changing version to 7.x, and changed the title to clarify as the issue is actually quite precise.