Closed (fixed)
Project:
Webform
Version:
5.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
26 Mar 2008 at 14:54 UTC
Updated:
6 Nov 2010 at 08:06 UTC
Jump to comment: Most recent file
Hey there. I need to use Webform for a new project, so I figured I'd just use this issue to keep track of my notes and stuff that I've seen whilst using it. To start, for the various things in admin/settings/webform:
More later, I suspect.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | p_238958_typos.patch | 9.08 KB | morbus iff |
Comments
Comment #1
quicksketchPatches? :)
Also, I'm barely upkeeping the 1.x version any more (just maintenance things). So if would review the 2.x version that would be helpful in the long run. Most of the things you bring up are still an issue in 2.x but things have been moved around quite a bit so I suspect there are both new and already fixed grammatical issues.
Comment #2
morbus iffHere ya go matey. Fixes everything above save for the placeholder in the Default subject (you already implemented that), and the use of 'e-mail' for the name of the component (I don't think it's important enough to warrant an upgrade path, nor do I want to move the filename in the cvs.) Applied against the 5--2 branch.
Comment #3
quicksketchThanks, committed. A lot of strings have been lingering in incorrect forms for quite a while as I try to prevent translations from breaking, but moving to 2.0 is the perfect time to be updating all these errors.
I committed the patch with 3 changes:
- Instead of using
!linkfor links I used<a href="!url">some text</a>. This makes it so that translators don't need to translate the text inside of the link separately.- I kept the link to wikipedia as part of the translatable string. This way translators can send users to the correct Wikipedia page in their own language.
- Trimmed up "Fieldsets allow you to organize numerous fields into a cohesive group." to just "Fieldsets allow you to organize multiple fields into a group."
Thanks for the patches, keep em coming :)
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.