Hey there. I need to use Webform for a new project, so I figured I'd just use this issue to keep track of my notes and stuff that I've seen whilst using it. To start, for the various things in admin/settings/webform:

  • "To add one select create content -> webform." should be "To add one, select Create content > Webform." (correction of menu item capitalization for D5 and beyond).
  • Don't shouldn't use "Below" or other positional words on a webpage. You never know how a theme could reorganize things. This is a standard thing-to-watch-for, even in book publishing. Remove all instances of "Below" and rework the sentence. Also, the intro to this settings page is pretty useless: it tells us what Webform is (that's already on the Modules page), and then the second sentence describes what's in a /hidden fieldset/ under /Advanced/ options. I'd remove the second sentence and use something like "Configure your Webform installation below."
  • "Below is a list of supported field types available for webform." Webform, here, should be capitalized since we're talking about features available to the entire module, not an individual or unique instance of a webform.
  • "Fieldsets allow you to organize complex webforms into groups of fields." Actually, it doesn't reorganize /webforms/, it reorganizes /fields/ (or, to use your existing lingo, /components/ in a webform. This should be reworded to "Fieldsets allow you to organize numerous fields into a cohesive group." or similar.
  • Why is the "email" field not named "e-mail"? Need an apostrophe on user's in "logged-in users e-mail.".
  • The markup description says "Presents a markup area of text." which is healthily confusion (since when is plain text actually markup, like HTML?). I'd re-describe this to "Displays the text as HTML in the form; does not render a field." or something.
  • Drupal fieldsets are not all capitalized: "Available Components" should be "Available components", "Default E-mail Values" should be "Default e-mail values" and so forth. This goes for all your other fields "From Name", "Default Subject", etc. and checkboxes ("Allow cookies for tracking submissions").
  • The "Default Subject" field should use placeholders. One shouldn't have to worry about leaving a space (per your help text), and one should have the ability to place the form name anywhere in the subject line. Code and replace this with "Form submission from !webform." and rewrite the help text (and don't repeat the form name in the help text. The first two words are "Default Subject.", which is just a restating of the field name. Not very helpful. Finally, there's a missing word: "If not other stated" should be "If not otherwise stated".
  • "Besides cookies, webform also" - you're talking about the module here, not a specific webform, so it should be capitalized. The earlier instance of "webform" in this help text is used properly.
  • "OFF" is garish. Just see "Off". Remove the last sentence about what I probably want to do. That's what default settings are for (which you've already implied via the default setting of OFF.)

More later, I suspect.

CommentFileSizeAuthor
#2 p_238958_typos.patch9.08 KBMorbus Iff
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

Patches? :)

Also, I'm barely upkeeping the 1.x version any more (just maintenance things). So if would review the 2.x version that would be helpful in the long run. Most of the things you bring up are still an issue in 2.x but things have been moved around quite a bit so I suspect there are both new and already fixed grammatical issues.

Morbus Iff’s picture

Version: 5.x-1.9 » 5.x-2.x-dev
Assigned: Unassigned » Morbus Iff
Status: Active » Needs review
FileSize
9.08 KB

Here ya go matey. Fixes everything above save for the placeholder in the Default subject (you already implemented that), and the use of 'e-mail' for the name of the component (I don't think it's important enough to warrant an upgrade path, nor do I want to move the filename in the cvs.) Applied against the 5--2 branch.

quicksketch’s picture

Status: Needs review » Fixed

Thanks, committed. A lot of strings have been lingering in incorrect forms for quite a while as I try to prevent translations from breaking, but moving to 2.0 is the perfect time to be updating all these errors.

I committed the patch with 3 changes:
- Instead of using !link for links I used <a href="!url">some text</a>. This makes it so that translators don't need to translate the text inside of the link separately.
- I kept the link to wikipedia as part of the translatable string. This way translators can send users to the correct Wikipedia page in their own language.
- Trimmed up "Fieldsets allow you to organize numerous fields into a cohesive group." to just "Fieldsets allow you to organize multiple fields into a group."

Thanks for the patches, keep em coming :)

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.