Patch for coding standards

moshe weitzman - March 26, 2008 - 19:18
Project:Diff
Version:6.x-2.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

This module needs a patch for code style. See coder.module to help identify errors. Especially needed is diffengine.php

#1

webernet - March 28, 2008 - 01:42
Category:feature request» task
Status:active» needs review

Untested, and probably incomplete.

Converts tabs to spaces, capitalizes TRUE/FALSE, adds {} to if statements etc.

AttachmentSize
patch.patch 58.39 KB

#2

webernet - April 4, 2008 - 16:06

No parse errors, all that's left should be CamelCase issues.

AttachmentSize
patch.patch 64.25 KB

#3

moshe weitzman - April 8, 2008 - 14:18
Status:needs review» fixed

committed to 6-2 branch. many thanks. i believe that camelcase is the standard for classes so no changes there. i could be wrong though.

it would be great if folks could review the theme_table() patch at http://drupal.org/node/239071. thats the last remaining hurdle before we write a patch for core.

#4

Anonymous (not verified) - April 22, 2008 - 14:21
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.