Closed (fixed)
Project:
SimpleTest
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Mar 2008 at 13:35 UTC
Updated:
18 Apr 2008 at 14:21 UTC
Jump to comment: Most recent file
This patch takes upload tests 90% of the way there
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | upload.patch | 18.9 KB | Rok Žlender |
| #8 | upload.patch | 13.34 KB | chx |
| #6 | upload.patch | 13.05 KB | chx |
| #5 | upload.patch | 11.64 KB | chx |
| #2 | noencode.patch | 10.13 KB | chx |
Comments
Comment #1
chx commentedComment #2
chx commentedSo, this gets rid of encoding and other cruft. Contact tests fail in the most peculiar manner, the third invalid (@site.) tests fail with
and that's not helped with anything I throw at it -- I tried even curClose and the login before every drupalPost in contact.test to no avail.
Comment #3
Rok Žlender commentedProblem is with curl and @ as first char http://si2.php.net/manual/en/ref.curl.php#74814 we would probably need to encode those something like
In line 48 of contact module works for me.
Comment #4
Rok Žlender commentedThat comment on php.net describes problem this one http://si2.php.net/manual/en/ref.curl.php#75044 a possible solution
Comment #5
chx commentedWe have problems with @ and arrays. I smell a bug or a missing feature, but this stuff codes around it. Does not yet work with upload but taxonomy and contact do pass.
Comment #6
chx commentedThere.
Edit: aside from doing uploads, this patch removes now unnecessary cleanup code, fixes taxonomy using story still and finally, assertResponse can be an array again. Sorry for producing a kitchen sink patch :) BTW. drupalVariableSet is now not needed, but that's a followup patch.
Comment #7
boombatower commentedSorry, HEAD changes frequently and it appears this no longer patches.
Comment #8
chx commentedit pains me that absolute minor problems hold back a patch for days. We are very short on time -- please let me know immediately via IRC or IM when something like this happens, reroll takes a minute or less.
Comment #9
Rok Žlender commentedRemoved some debuging stuff from chxs patch and made some changes to upload test. We still have one fail in upload test but that is not caused by this issue.
Comment #10
Rok Žlender commentedCommitted patch #9 thanks chx
Comment #11
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.