I tried to use the panels "two columns stacked" and "Three column 33/34/33" layouts with my RTL site. Everything worked fine with Firefox, and even with IE7 (1024x768) - but suddenly I've got complaints from customers that the right column is displayed below the left column(s), and becomes a white, empty space. I was able to reproduce it on my computer when I resized the window to 800x600 resolution.

Adding RTL support for the "twocol stacked" layout is a simple issue of changing the width of each panel in threecol_33_34_33.css from 50% to 49.9%. This is similar to what was done with the "panel-col-bottom" panel, and it doesn't break firefox. Enlightened, I've tried to use a similar approach for the "Three column 33/34/33" layout by leaving a little air and changing the width of the central panel from 34% to 33% in panels_layouts_threecol_33_34_33.css.

Sigh of relief and a smile on my face - mission completed.

Is it so? Please test the attached patches and verify that they don't break the regular layout.

Conclusions and Insights:
1. Don't eat the whole cake. Leave a little percent to breath!
2. This may work for other panel styles as well - please test :)

Comments

druvision’s picture

Status: Needs review » Fixed

Thanks! The issue was fixed in panels-5.x-2.0 beta3. I've tested the layouts mentioned above to work correctly.

druvision’s picture

Status: Fixed » Needs work

Other layouts should probably be changed accordingly (I haven't tested it yet).

esmerel’s picture

Status: Needs work » Fixed

Fixed in beta, No further fixes are going to get committed to the 2.x line

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.