Tracker Module Tests

Marking needs review. No time to do it myself atm.

I was hoping dmitrig01 would post his and we could compare/merge, but that doesn't seem to be happening so I'll review yours tomorrow.

Here they are, my very special tracker tests.

With the tests this time!

@dmitrig01: I noticed a few things that I would appreciate if they were cleaned up.

• I not sure the drupalCreateNodes method is necessary, and if it is I would like to have others approve it. The comment has a bit of random spacing and is missing periods.
• It has been agreed that tests should have documentation on the methods. If you would add that it would be appreciated.
• All comments should end with a period.
• All displayed messages should be wrapped with t().
• Most tests use the $message parameter with asserts to make it more clear what the test is doing. That isn't necessary, but nice.
• It isn't necessary to implement tearDown just to call parent.
• It seems the following code is common to all the test methods and should be moved to setUp.
  

  // Enable the comment and tracker modules
  $this->drupalModuleEnable('comment');
  $this->drupalModuleEnable('tracker');
  // Create some nodes, a user, etc.
  $data = $this->trackerPostNodes();
  

You can look at the tests that I have reviewed to see an example of what we are looking for.

The changes are minor, but the test as a whole looks nice.

Thanks.

http://drupal.org/node/253500 was duplicate.

I think boombatower's review still stands.

I agree with boombatower's comments. The patch from #5 is also not structured like any existing core texts:

* Its use of xpath is very powerful, but also very obscure.
* Direct calls to curlExec() are a big no-no, they belong in the testing framework, not in the tests themselves.
* Why do we need to test everything on multiple nodes at once? Unless we're looking for a specific behavior when dealing with multiple nodes, we shouldn't test on multiple nodes. There's no need to add unrelated parameters to a test.

Here's a simpler test that covers the same functionality.

Although the patch from #1 needs some clean-up, it covers some code that is not covered by dmitrig01's patch or mine. I'll work on merging these tests.

After a closer look, the only case checked by the patch from #1 that I was missing was that unpublished nodes should not show up in the tracker listing.

This patch is much cleaner than the original. It passes on my dev box and seems to be much more consistent with other tests.

I removed several page content outputs that seem to be left over from development and cleaned up some white-spacing.

Good work flobruit.

Change component is relation to http://drupal.org/node/253744.

Committed to CVS HEAD. Thanks all.