Hi guys,

thanks for great module, but after testing it I have to admit that it is sort of useless due to a number of strange things.

With the advanced display option - where is the floating option? And - the font has changed in the node, it looks like it is caused by this module's css. I mean - it is really great to have an option to place images in the text where I want, but it is useless as these doesn't float.

Of course - I can use the other options, which works great, but again - what is the point of having images in teaser even when I choose display at the "bottom"? If you have story with 8-10 images (which is not too many at all) - do you usually display them all in the teaser? I don't think so...

Nevertheless - great module, but carry on with development, take my notices into account and I hope we'll get decent functionality soon!

Good luck!

CommentFileSizeAuthor
#2 screenshot.jpg56.95 KBpetiar

Comments

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented

Please give me detailed bug report because I don't understand you problem.

1) To float an image use align=float_left or float_right. But again.
2) Is the font changed in the node's code? I don't think so. Validate your page and inspect the unclosed html tags. http://validator.w3.org/
3) There is an option to limit the maximum number of images displayed in teaser.

Still useless? Don't use it.

petiar’s picture

petiar commented
StatusFileSize
new screenshot.jpg56.95 KB

Doh!!! I feel so stupid now. Please, ignore my notice about images in teaser as well as the one regarding floating. I promise I'll go through the user interface properly next time.

Regarding the font change - the validator says that the first div after the p tag is wrong in:
<div class="content"><p><div class="img_div"><div class="img_box "

(document type does not allow element "div" here)

Any ideas? Actually, only the size of the font has changed (see the attached screenshot).

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented
Title: Looks nice, but almost useless. » The 'advanced mode' and 'Line break converter' filter combination produces non-valid HTML pages

It is because of a conflict between the 'advanced mode' and the 'Line break converter' Drupal core filter. It doesn't happen with the 'basic mode'.

The div tags get enclosed into p html tags.

First the 'line break converter' produces the

 <p>[img:1]</p>

and after that it becomes

<p><div class="img_box img_left" style="width:310px"><div class="img_image"><a href="http://project.para.ro/sites/project.para.ro/files/Untitled_1.gif" rel="lightbox[95]" title="Untitled_1.gif"><img src="http://project.para.ro/sites/project.para.ro/files/img_thumbnails/95_422.gif" alt="Untitled_1.gif" title="Untitled_1.gif" class="img" width="300px" /></a></div><div class="img_title_bottom">Untitled_1.gif</div></div></p>

Hm.

petiar’s picture

petiar commented

Yep, I noticed this. The question is - are you going to fix this? Our users are mostly musicians not very experience in HTML so we need to use that line break converter filter.

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented

If they are musicians they won't use the advanced mode (like my users on http://para.ro (they are painters). They will use the default mode you set.

Anyway I'll try to fix this.

petiar’s picture

petiar commented
Title: The 'advanced mode' and 'Line break converter' filter combination produces non-valid HTML pages » Looks nice, but almost useless.

Yep, but my understanding is that the paragraph/line break filter actually causes this problem. And as our users are not very experienced with (X)HTML I need to use that filter, because it easier for them to press 'Return' on keyboard then type <p> or <br /> tags in the text. Makes sense?

Or did you mean that this filter doesn't cause this issue if it is being used in basic mode? I can give it a try. Thanks anyway!

Petiar.

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented

Right. The basic mode has no this issue.

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented
Title: Looks nice, but almost useless. » The 'advanced mode' and 'Line break converter' filter combination produces non-valid HTML pages

Don't change the title back. This is what is happens.

petiar’s picture

petiar commented

I swear I didn't - not by purpose. It must have been in my browser's cache and I didn't notice. Also now was the old (silly) one in the 'Issue title' field by default - do not know why. Sorry for that.

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented
Status: Active » Closed (duplicate)

Please see http://drupal.org/node/242385. Marked this as duplicate.

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 150270)