When you quote someone and enter a name

[quote=PyromanFO][quote=Mixolyde] pyro text[/quote]Mix text[/quote]

the output looks like this

PyromanFO wrote:

[quote=Mixolyde] pyro text
Mix text

[/quote]

Any ideas how to fix the regex?

CommentFileSizeAuthor
#2 bbcode-filter-fix_0.patch3.34 KBpyromanfo
#1 bbcode-filter-fix.patch2.03 KBpyromanfo

Comments

pyromanfo’s picture

pyromanfo commented
StatusFileSize
new bbcode-filter-fix.patch2.03 KB

Attached is a patch to fix this, slight speed hit but with filtercache this small of a hit shouldn't matter.

It basically has to seperate out the quote regexes and run through them a few times to catch quotes within quotes. It also tweaks the regex to allow this to happen.

pyromanfo’s picture

pyromanfo commented
StatusFileSize
new bbcode-filter-fix_0.patch3.34 KB

Here is a better patch to fix this, it's alot more robust and faster.

moggy’s picture

moggy commented
Status: Needs review » Reviewed & tested by the community

This seems to work well.

Now all we need is a friendly developer to commit this.

naudefj’s picture

naudefj commented
Status: Reviewed & tested by the community » Needs work

This patch defines an array $quote_preg that is never used. Please cleanup and resubmit so we can get it committed ASAP.

naudefj’s picture

naudefj commented
Assigned: Unassigned » naudefj
Status: Needs work » Fixed

Added to CVS - see http://cvs.drupal.org/viewcvs/drupal/contributions/modules/bbcode/bbcode...

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)