The module is modified so that the administrator can choose the password reset method
from the two possible options:
1- Use secret questions previously set by the administrator (this is what the original version does)
2- Use user custom questions.
The number of user custom questions to be used in the second case is set by the administrator to a number from 1 to 5. User enters his/her own question(s) and answer(s).

CommentFileSizeAuthor
password_reset_module.patch27.94 KByarimbiyik
password_reset_install.patch1.6 KByarimbiyik

Comments

yarimbiyik’s picture

yarimbiyik commented
Status: Active » Needs review
Zen’s picture

Zen commented
Status: Needs review » Needs work

I have only give the patch a quick visual browse.

  • While I think that allowing the user to choose his own question is a good feature, I'm not too chuffed with the approach. The black and white approach - choose admin presets or choose custom questions - is not very friendly. The option, IMO, ought to be, "allow user to add his own question" that if enabled offers an "add your own question" link on the registration form which will allow the user to add his own question. This should also not involve redirection to a new page (i.e., should involve JS and an extra couple of textfields) as that will impede the registration process.
  • Please don't introduce other changes such as changing the answer field into a password field.
  • Please run your patched module through the coder module's code review to fix all the code style issues.
  • Please remove all the attribution text in the file - attribution is added in the commit message only.
  • Please remove all trailing whitespace. Only two space indentations and plenty of other similar issues can also be fixed.

Thanks Arif.
-K

Zen’s picture

Zen commented

The extra DB table is also unnecessary. It can be merged into the password_reset table along with a type field to differentiate between admin presets and custom questions.