Should the CVS commit message include the diff?

Archived poll results:

  • Yes! (16 votes)
  • Don't care. (6 votes)
  • No! (6 votes)
  • Say what? (4 votes)

I would like the commit

killes@www.drop.org - June 13, 2002 - 12:40

messages to be assembled somewherer in CVS.

Just use cvs log ?

Anonymous - June 13, 2002 - 13:51

Just use cvs log ?

Maybe

killes@www.drop.org - June 13, 2002 - 16:17

but how does it work?

cvs log

Kjartan - June 14, 2002 - 09:12

Usage: cvs log [-lRhtNb] [-r[revisions]] [-d dates] [-s states]
    [-w[logins]] [files...]
-l Local directory only, no recursion.
-R Only print name of RCS file.
-h Only print header.
-t Only print header and descriptive text.
-N Do not list tags.
-b Only list revisions on the default branch.
-r[revisions] Specify revision(s)s to list.
   rev1:rev2   Between rev1 and rev2, including rev1 and rev2.
   rev1::rev2  Between rev1 and rev2, excluding rev1 and rev2.
   rev:        rev and following revisions on the same branch.
   rev::       After rev on the same branch.
   :rev        rev and previous revisions on the same branch.
   ::rev       Before rev on the same branch.
   rev         Just rev.
   branch      All revisions on the branch.
   branch.     The last revision on the branch.
-d dates Specify dates (D1<D2 for range, D for latest before).
-s states Only list revisions with specified states.
-w[logins] Only list revisions checked in by specified logins.
--
Kjartan

no thanks - encourages laziness

moshe weitzman - June 14, 2002 - 16:43

i'd rather not see the diff on the CVS commit I think that developers will skip describing their changes and just let the diff speak for itself. This is not how normal humans communicate

Its not like that many people

Kjartan - June 15, 2002 - 13:51

Its not like that many people have access to commit stuff to the main repository

I'm sure we could work something out. Personally it don't matter much to me. Its pretty easy to take a diff anyways. Some people have been asking for it so before I spend any time to set it up figured I would see how many people are interested in it.

--
Kjartan

i dont really understand ...

ax - June 17, 2002 - 23:40

... how comes 46% (time of writing) vote PRO "include diff in commit message". to me this looks completely stupid (I can't think of the better english word that there is at the moment). just imagine a 100-lines-change ... the commit message, as moshe says, just is not meant to include the diff - it is meant to be a concise description of the changes in human language.

then the 46% must be because of difficulties getting the diffs. but this is really easy:

http://cvs.drupal.org/viewcvs.cgi/drupal/[the_file].diff?r1=[rev1]&r2=[rev2]

easily accessible from http://cvs.drupal.org/. guess this just has to be communicated ...

maybe we could include a link to this diff into the log (not: commit) messages.

have to register some new names to straighten that out

Such a link would be probably

Dries - June 21, 2002 - 05:01

Such a link would be probably the best solution, IMO! Good thinking.

Yes!

Kjartan - June 25, 2002 - 10:22

I like this one. I'll do this one. Assuming I can figure out how

--
Kjartan

nice smiley on your post

moshe weitzman - June 26, 2002 - 16:09
 
 

Drupal is a registered trademark of Dries Buytaert.