Fix problems with node attribute checking (and improve defaults) [#24003]

One side effect of the node system is that all the default node flags (promote, revisions, etc) have only one default setting for all node types.

The most meaningless result of that IMO is that forum topics are promoted to the front page by default. This is probably one of the most confusing things people run into when setting up a Drupal forum.

The attached patch adds a row to the variable table to force forum topics to not be promoted by default. This will only affect new installations.

Patch is for CVS, but IMO it should go in 4.6 too.

Comment	File	Size	Author
#2	forumpromote_0.patch	2.57 KB	Steven
#2
	forumpromote.patch	1.14 KB	Steven

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Steven CreditAttribution: Steven commented 31 May 2005 at 18:32

Sorry I based this on a quick glance at my variables table which seemed to be stale. But I've noticed a problem with the way node options are checked in blogapi. Better patch coming.

Comment #2

Steven CreditAttribution: Steven commented 31 May 2005 at 19:47

Title:

Don't promote forum topics by default

» Fix problems with node attribute checking (and improve defaults)

File	Size
forumpromote_0.patch	2.57 KB

Okay this patch is now a little different ;). It fixes the checking of attributes in blogapi: not only was the default for the variable wrong, but it also checked for array keys rather than array values.

Finally, I fixed the database.sql fix so it correctly makes forum topics not be promoted by default.