Patch is attached.

CommentFileSizeAuthor
#3 feedapi-more_coder_format.patch9 KBmustafau
#2 feedapi-more_coder_format.patch4.92 KBmustafau
feedapi_coder_warnings.patch4.6 KBmustafau

Comments

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs review » Fixed

Thank you, this is really awesome, i applied your patch and run through the coder module on other feedapi modules (aggregator, for example), so now all feedapi for 5.x is coder-safe :)

mustafau’s picture

mustafau commented
Assigned: Unassigned » mustafau
Status: Fixed » Needs work
StatusFileSize
new feedapi-more_coder_format.patch4.92 KB

It seems that coder module does not catch everything. I found some other errors. Patch is attached.

mustafau’s picture

mustafau commented
Status: Needs work » Needs review
StatusFileSize
new feedapi-more_coder_format.patch9 KB

Updated.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs review » Fixed

Thanks, it's committed for both 5.x and 6.x branches. I also run through coder module again in the two codebases and i fixed the warnings where it's possible.
Btw:

$a = $b. $c;

How to write this to avoid coder module complain? :)

mustafau’s picture

mustafau commented

$a = $b . $c;

mustafau’s picture

mustafau commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Assigned: mustafau » Unassigned

Two little errors:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/feedapi/fee...
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/feedapi/par...

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.