Posted by mustafau on March 29, 2008 at 3:40pm
| Project: | FeedAPI |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Patch is attached.
| Attachment | Size |
|---|---|
| feedapi_coder_warnings.patch | 4.6 KB |
Comments
#1
Thank you, this is really awesome, i applied your patch and run through the coder module on other feedapi modules (aggregator, for example), so now all feedapi for 5.x is coder-safe :)
#2
It seems that coder module does not catch everything. I found some other errors. Patch is attached.
#3
Updated.
#4
Thanks, it's committed for both 5.x and 6.x branches. I also run through coder module again in the two codebases and i fixed the warnings where it's possible.
Btw:
$a = $b. $c;How to write this to avoid coder module complain? :)
#5
<?php$a = $b . $c;
?>
#6
Two little errors:
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/feedapi/fee...
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/feedapi/par...
#7
Automatically closed -- issue fixed for two weeks with no activity.