Incorrect watchdog call
NancyDru - March 29, 2008 - 16:40
| Project: | Comment Subscribe |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | zyxware |
| Status: | won't fix |
Jump to:
Description
I found this because of http://drupal.org/node/239084.
Function _comment_subscribe_mailalert has a watchdog call that is incorrect for 6.x:
watchdog('comment_subscribe', t('Subscribe ') . $mylink,
WATCHDOG_NOTICE, l(t('source comment'), 'node/'. $nid, array('fragment' => 'comment-'. $alert->cid)));Needs to be something like:
watchdog('comment_subscribe', 'Subscribe !link', array('!link' => $mylink),
WATCHDOG_NOTICE, l(t('source comment'), 'node/'. $nid, array('fragment' => 'comment-'. $alert->cid)));In addition I see many coding standards violations in this module. Please use the Coder module to identify them. It probably would also have alerted you to the watchdog changes.
#1
The error has been fixed and updated in the next version.
Cheers
zyxware
#2
Thank you. Please mark this issue fixed when it has been committed (even if only to the -dev release).
#3
Marking the issue as fixed
#4
Automatically closed -- issue fixed for two weeks with no activity.
#5
I just d/l'ed this module off the modules page, and the bug was still there. I'll go to CVS and see if I can find a more current version, but I thought you should know.
#6
#7
I'm coming from this thread http://drupal.org/node/260430 which I posted a few weeks ago.
Which file do I need to access in order to edit the function _comment_subscribe_mailalert as mentioned above.
#8
Hi superjacent,
You have to edit comment_subscribe.module file in comment_subscribe module.
Regards
zyxware
#9
In addition, the first parameter to watchdog() is limited to 16 characters if the database logging module is installed (true for a guess of about 99% of Drupal sites). "comment_subscribe" is 17 characters and will fail the SQL query. Please change it to "comment_subscrib" or "commentsubscribe".
#10
EDIT: Removed comment. Posted in wrong issue. :)
#11
It has been decided to merge Comment Subscribe module with the Comment Notify module as both currently have the same set of functionalities. We have stopped our support here and will be providing our support at the Comment Notify issue queue. To help you seamlessly migrate to Comment Notify, we have provided an easy migration pathway using the last update - 6.x-1.4. Migration instructions are provided at the Comment Subscribe project home page . Once again thank you all for your wonderful support and contributions towards this module. See you all at the Comment Notify issue queue :-)