sql error when node_load() is called before type_local_nids_nodeapi() is called with $op = 'insert'

Thanks for reporting this. I hadn't tested the 6.x version as much as the 5.x. It's now fixed in 6.x-1.2.

I just needed to ensure that the lnid is loaded during 'update', as it seems D6 does load the node before updating it.

Whenever the 'insert' operation is called the $node->lnid is false, causing the _type_local_nids_generate_lnid function call, that's not the expected behaviour. I change one line of code to load the 'lnid' property before 'insert' and 'update'.

function type_local_nids_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {

	switch ($op) {
	
		case 'load':
		case 'insert': // this line was changed
		case 'update':
		
			$node->lnid = db_result(db_query("
				SELECT lnid
				FROM {node_lnid}
				WHERE nid = %d
			",
				$node->nid
			));

			if(!$node->lnid)
				_type_local_nids_generate_lnid($node);

			return array('lnid' => $node->lnid);

		case 'delete':
		
			db_query("
				DELETE FROM {node_lnid}
				WHERE nid = %d
			",
				$node->nid
			);
			
			break;
	}
}

Node insertion is the time when _type_local_nids_generate_lnid() should most definitely be called. Thats the whole point of the module.

There is no point in checking if a node has a lnid when it is being created as there is no way it could have one yet.

Seems some modules (I'm looking at you og_subgroups) call node_load during hook_nodeapi() with $op = 'insert'.

http://drupal.org/cvs?commit=266288