Filter module review.

This patch cleans up the code, adds comment blocks were necessary.

The test previously passed HEAD and passes after the patch. The patched removed allot of unnecessary regular expressions that have been outdated due to the new internal browser's support for assertField.

Included in this patch is a fix for the assertFieldByXPath method to handle multiple fields when checking values correctly. This is necessary on the filter page with the radio inputs.

CommentFileSizeAuthor
simpletest_review_filter.patch11.13 KBboombatower

Comments

boombatower’s picture

boombatower commented

The modification to the assertNoFieldByXPath method causes some issues with comment. I'm holding off till I can figure them out.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Needs work

Marking as a patch.

boombatower’s picture

boombatower commented
Status: Needs work » Fixed

Committed.

Determined that the change to the assertNoFieldByXPath works correctly and there is an issue with the comment test.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.