Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Filter module review.
This patch cleans up the code, adds comment blocks were necessary.
The test previously passed HEAD and passes after the patch. The patched removed allot of unnecessary regular expressions that have been outdated due to the new internal browser's support for assertField
.
Included in this patch is a fix for the assertFieldByXPath
method to handle multiple fields when checking values correctly. This is necessary on the filter page with the radio inputs.
Comment | File | Size | Author |
---|---|---|---|
simpletest_review_filter.patch | 11.13 KB | boombatower | |
Comments
Comment #1
boombatower CreditAttribution: boombatower commentedThe modification to the
assertNoFieldByXPath
method causes some issues with comment. I'm holding off till I can figure them out.Comment #2
webchickMarking as a patch.
Comment #3
boombatower CreditAttribution: boombatower commentedCommitted.
Determined that the change to the
assertNoFieldByXPath
works correctly and there is an issue with the comment test.Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.