Review: Filter Module Test
boombatower - March 30, 2008 - 23:37
| Project: | SimpleTest |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | boombatower |
| Status: | closed |
Jump to:
Description
Filter module review.
This patch cleans up the code, adds comment blocks were necessary.
The test previously passed HEAD and passes after the patch. The patched removed allot of unnecessary regular expressions that have been outdated due to the new internal browser's support for assertField.
Included in this patch is a fix for the assertFieldByXPath method to handle multiple fields when checking values correctly. This is necessary on the filter page with the radio inputs.
| Attachment | Size |
|---|---|
| simpletest_review_filter.patch | 11.13 KB |
#1
The modification to the
assertNoFieldByXPathmethod causes some issues with comment. I'm holding off till I can figure them out.#2
Marking as a patch.
#3
Committed.
Determined that the change to the
assertNoFieldByXPathworks correctly and there is an issue with the comment test.#4
Automatically closed -- issue fixed for two weeks with no activity.