I noticed after upgrading to the latest module you just released tonight that the secondary class was no longer applied to my secondary Tabs. Instead both sets of tabs received the primary class.

I was doing to template work and was not sure what had happened .. so after some firebugin and such I reverted just the tabs sub folder to the previous version, and now my classes are applied correctly.

Is there a needed change in the script for my page.tpl file?

	<?php if ($mission): print '<div id="mission">'. $mission .'</div>'; endif; ?>
        <?php if ($tabs): print '<div id="tabs-wrapper" class="clear-block">'; endif; ?>
        <?php if ($title): print '<h2'. ($tabs ? ' class="with-tabs"' : '') .'>'. $title .'</h2>'; endif; ?>
        <?php if ($tabs): print $tabs .'</div>'; endif; ?>
        <?php if (isset($tabs2)): print $tabs2; endif; ?>
        <?php if ($help): print $help; endif; ?>

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks for the note, not sure what the issue is. I do recall making some changes in the class handling when upgrading to 6.x, possibly I need to backport a fix.

Macronomicus’s picture

Macronomicus commented

Did some more digging ... the workaround I mentioned above only seemed to work on my local testing server (WAMP) once I uploaded it to my actual online server (Apache2.2.3 (CentOS) the classes became messed up again. So i undid my work around and applied the proper tabs from 5.x-1.0 ... then they didnt even work at all LOL!

I use the primary class for my drupal admin tabs only, and they dont really even look like tabs persey just a horiz menu. The secondary class for all others is more styled ... also I like the nested tabs to look the same as what their nested in for consistency.

This prolly has more to do with my template ... but it was working before then it didnt, so I just had to do something! and it worked for me. LOL im sure its silly as im no JS pro but at least I found the culprit code right? Or just got lucky it worked! ^_^

So I did a silly little tiny hack on the tabs.js file ... on line 27.

Changed from
27 var newClass = $(this).parents('.drupal-tabs').size() > 1 ? 'secondary' : 'primary';

to.....

27 var newClass = $(this).parents('.drupal-tabs').size() > 1 ? 'secondary' : 'secondary';

Im sure this is not too proper? I did try to strip the second item but it broke it so ... well im just glad its working for now.

Cheers ^_^