When I run the upgrade script to go from 5.x-1.0 to 5.x-2.0 it never finishes. I've looked at the code and it seems like its just redoing the first 50 items over and over. I'm sure I'm reading it wrong though.

I had about 1400 feed items originally (it seems they never got deleted after the 1 week). Now, they seem to be duplicating. I have a number of feeds that it is retrieving multiple times. I'm sure this has to do with the new hash algorithm, but if you could suggest a way to fix things, I'd appreciate it.

Comments

mfer’s picture

mfer commented
Component: Documentation » Code
Category: support » bug

I had the same problem except mine got through the update script and all my items were updated. It still never finished and kept repeating the update.

Jeroen Coumans’s picture

Jeroen Coumans commented

Same problem, with more than 2000 feed items. I use mine as an aggregation for delicious, and configured them to never delete. I also see my feed items duplicating again (which is really frustrating).

mfer’s picture

mfer commented

There is an error in the update script. It's just doing the same 50 over and over. The problem is in

  $feed_items = db_query_range('SELECT r.vid, r.title, r.body FROM {node_revisions} r JOIN {simplefeed_feed_item} s ON r.vid = s.vid ORDER BY r.vid ASC', 0, $limit);

$limit is set to 50. In this case it's just going to do the same 50 items over and over.

Jeroen Coumans’s picture

Jeroen Coumans commented

Ah yes, setting it to a higher value will allow the update script to finish!

m3avrck’s picture

m3avrck commented

That would explain in my testing it worked great, I never had more than 50 items, haha.

The code was based an example Steven wrote must have changed the limit wrong, will look at soon, if someone can post a patch that would be great :)

Great catch Matt!

m3avrck’s picture

m3avrck commented
Status: Active » Fixed

This has been fixed with a new update_2 which now works: http://drupal.org/cvs?commit=120679

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.