Two Bugs, a Patch and Something Odd

Environment: Drupal 4.6, Apache 1.3.x, PHP 4.3.x, MySQL 4
cvs header: $Id: workspace.module,v 1.16 2005/02/23 15:32:18 jvandyk Exp $

First of all, thank you for putting this together. It makes content and comment tracking really easy and I use it every day on MutantMedia.

Second, there are a couple pager_query() headers that, when clicked on, throw a SQL error and get logged, but don't have any output. These fields are Owner and Replies. I fixed them both with a patch, attached.

Third, something odd. If you try to sort workspace's pager_query() using columns that are not applicable to both nodes and comments, such as node.status, the output from the ORDER BY clauses appears to be filled simultaneously from each of the UNION'd output sets. For instance:

Type... | Title...................... | Published [sort icon: desc]
--------------------------------------------------------------------
comment	| New Missions............... | yes	
page... | The Game of Carrion (Draft) | no
comment	| Carrion Cards.............. | yes
page... | The Game of Cadaver (Draft) | no

Now then, I'm no SQL expert and I don't know exactly why this is happening. However, I think it's a problem somewhere under pager_query(), which means it's a Drupal code "problem" and no fault of workspace.module's.