Closed (fixed)
Project:
RSVP
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Jun 2005 at 21:04 UTC
Updated:
8 Oct 2005 at 07:20 UTC
Jump to comment: Most recent file
Environment: Drupal 4.6, Apache 1.3.x, PHP 4.3.x, MySQL 4
cvs header: $Id: rsvp.module,v 1.6 2005/03/25 06:51:25 crunchywelch Exp $
This is a pretty cool module. Thank you for building it!
RSVP for Drupal 4.6 doesn't make use of drupalcore's format_date() function, which breaks RSVP's date display on some systems (like mine). This patch modified rsvp.module to use drupal's format_date() function in "small" mode, so dates are shown using the user-selected small format from the drupal site's admin/settings page.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | rsvp.theme | 1.95 KB | Carlos Miranda Levy |
| #10 | rsvp_0.module | 41.02 KB | Carlos Miranda Levy |
| #7 | rsvp_module_format_date.patch | 6.49 KB | dtan |
| #3 | rsvp.module.format_date.patch | 6.49 KB | dtan |
| #1 | rsvp.4-6.drupal-format_date-theme.patch | 412 bytes | Travis |
Comments
Comment #1
Travis commentedLooks like I missed a spot. Another non-drupal date() call was in rsvp.theme, so this patch updates that file.
It's also worth mentioning that these patches fix a bug where rsvp displays the date of the epoch [ie. date(0);] instead of the date of the event because it tries to use the event's $node->start instead of $node->start_offset.
Comment #2
Travis commentedTwo patches, one for the .module and one for the .theme
Comment #3
dtan commentedHere is the patch rolled into 1 with a slight localization fix to the strings where they are used.
Comment #4
HrlyKrs commentedAm I doing something wrong? I read through the post about Diff vs Patch
I also tried just:
I even tried moving the patch into the same directory:
Comment #5
dtan commentedtry patch --help and read the options. . . take note of the -p option. Also you might want to try patch [original_file] [patchfile]
Comment #6
HrlyKrs commentedI know what the problem was. i was retreving the file with wget, and it was coming in as one line. i downloaded the file, and transfered it over to my Linux box. i am now getting a different error:
Comment #7
dtan commentedya, my bad, well kinda. I used a bad naming scheme for the patch and the project/upload module added html to the patch. my apologies
Comment #8
HrlyKrs commentedI am getting the same error:
Comment #9
HrlyKrs commentedplease disregard my previous post. I was using the old file. the patch worked fine.
Comment #10
Carlos Miranda Levy commentedFor those who can't patch (like myself), here is the rsvp.module file patched to fix the date display problem.
This is for the module dated March 24, 2005 for Drupal 4.6.
I did the patch by hand, since I have yet to find a patch tool that works on xp without crashing...
Comment #11
Carlos Miranda Levy commentedFor those who can't patch (like myself), here is the rsvp.theme file patched to fix the date display problem.
This is for the module dated March 24, 2005 for Drupal 4.6.
I did the patch by hand, since I have yet to find a patch tool that works on xp without crashing...
Comment #12
ankur commentedApplied to HEAD and DRUPAL-4-6 with crunchywelch's permission.
-Ankur
Comment #13
(not verified) commentedComment #14
(not verified) commentedComment #15
(not verified) commentedComment #16
(not verified) commentedComment #17
(not verified) commented