The attached patch *should* port the mark as read functionality to Drupal 6.

It is, however, totally untested. It may be broken.

What it does:

1. Updated menu code. Not tested and I did remove the User id as part of the access check...
2. Actual function has been updated to work on all content types in a forum. Not tested, but this should work.

This time as a proper patch!

CommentFileSizeAuthor
markasread.patch3.2 KBnaheemsays

Comments

naheemsays’s picture

naheemsays commented

Just thinking this a little further... why is there an access permissions check? I think the two access lines (callback and arguments) should be able to be replaced with:

'access callback' => TRUE,

That is unless I am missing something?

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Thanks. I hope to be getting back to the D6 port again soon. I got bogged down with things not working right in D5 and needed to get them fixed since the 5.x version is being used on live sites. So the D6 port kinda got the shaft for a while. :(

Michelle

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Needs review » Needs work

This patch doesn't work but I've made some progress towards getting it working. There is still an error when marking a single forum read. Also, as noted over here there is still a problem with the menu call.

I committed the partial fix because it was part of a package of fixes I did last night and I didn't get it all the way done before I had to go, but it's not ready to use, yet. (Not that the dev is, either, but that's another story. :P)

Michelle

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Needs work » Fixed

Thanks for the effort, nbz, but I wasn't able to use this patch after all. The patch was pretty broken and, in the process of trying to fix it, I discovered the original code that I got from someone else to use in the 5.x line was actually pretty bad. With help from afeijo (who rewrote it and did the bulk of the work) and konfused on IRC, we now have a much clearer and working version. It's only had minimal testing but seems to work just fine.

Michelle

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.