I replaced help that was provided in a fieldset with the regular Drupal help hook and added some more.

Note: Submitting patches guide mention If your patch is just a quick hack, then don't set your issue to patch (code needs review) status, instead set it to active or patch (code needs work).

CommentFileSizeAuthor
help.patch3.38 KBdynv

Comments

david lesieur’s picture

The help text is referring to features that are not implemented yet. Patch thus cannot be committed.

Could use the heredoc syntax instead of concatenating multple strings.

More fundamentally, I'm not sure it is a good idea to remove the current help from the admin page where it is actually helpful, and move it to a help page where people seldom go...

dynv’s picture

As in the screenshot I once showed you in an email http://picasaweb.google.com/DynVec/Screenshots/photo#5166775917768284850 , there's two section in that help section (switch ($section)), which also the page you're referring.

Thanks for the heredoc suggestion, I'll look into it.

For the committing part, I don't know much about it, this was just splitting the whole modification and I though you'd commit everything at the same time once it was modified appropriately.

dynv’s picture

I looked at a few core modules and the help in those are done like mine so I think this module should go this way.

dynv’s picture

Status: Needs work » Closed (fixed)

Dropped the separation and included in #241155: Root Title, Min. Level, Limit and Dept

dynv’s picture

Assigned: Unassigned » dynv