Patch for SMTP RFC compliance, array init typo

Environment: Drupal 4.6, Apache 1.3.x, PHP 4.3.x, MySQL 4
cvs header: $Id: rsvp.module,v 1.6 2005/03/25 06:51:25 crunchywelch Exp $

Outgoing mail "to:" envelope fields are created incorrectly:

$to = $invite->email;

... for invitation emails and ...

$to = "$attendee->email <". $attendee->email .'>';

... for emails sent from the "send message" tab.

Neither of these fields is RFC compliant. Some mail servers (ie. Exim) will throw a 550 when it encounters an envelope friendly name that is identical to the destination mailbox portion. For instance:

A message that you sent contained one or more recipient addresses that were incorrectly constructed:

  deixis@mutantmedia.net <deixis@mutantmedia.net>: malformed address: <deixis@mutantmedia.net> may not follow deixis@mutantmedia.net

This address has been ignored.

On lines 1223 and 1224 in function _rsvp_mail_rsvp($rid, $resend = FALSE), the $success array is initialized but never used, but is quite similar to the $status array in function _rsvp_message_rsvp($edit), which is used. I assume this was a silly typo that was never caught, so I fixed it with this patch as well.