Rickroll.module to core

Let's be serious, ok?

Can you backport this to 5.x? I was working on something similar, but your implementation is far cleaner. A full commitment's what I'm thinking of..

return $lyrics;

ROFL, brilliant. This gets a +1 from me.

+1 from me.

Webchick obviously doesn't know what day it is. ;-p

Yeah, we need an 'April fools' status for.

Oh, it's a joke?

File this in g.d.o in the "Drupal for Evil" group, please.

The function rickroll_enable() has uneven spacing for its last line and therefore does not comply with core coding standards.

I can't believe someone actually wrote 200+ lines of code to pull this off. LOL

Woot! Rickroll in core! :) +1

Ah, 1987.

@bjaspan You know the rules, and so do I.

if($date = 1st April){
rickroll_enable()
}
else{

}

+1.

*subscribe* ;-)

+1 A+++++++++++WILL COMMIT AGAIN!!!!!1111

Go on, commit it today and roll back by midnight. There's still time!!!!

Oh wait. No SimpleTests?

+1 on the concept.

You need to run it thru coder though.

The function _rickroll_video_default has the wrong tabs, so does rickroll_block.

The trailing ?> needs to go too.

Code style is good - nicely abstracted - RTBC.

subscribing

+1
Love it.

What the......

Did I just get rickroll'd?

Before we get this into core, we need to guarantee that the look will be consistent with most themes. Based on catch's comment in #10, this patch adds rickroll.css to this module:

#main {
  background: url(http://daz.com/img/00/00/00/7417.jpg) repeat;
}

This provides both aesthetic and usability improvements, and if you have firebug installed you can test it on this page with the "Blue Beach".

edit: Sorry, patch was broken. Re-rolling.

I tested this patch against a 7.x sandbox, and the patch needs some work. There seem to be to many "+?" styles in the CSS code, and it causes a White and Black Screen Of Death.

I had to un-apply the patch just to get my sandbox .bak

Please re-roll this for 6 as well, once you figure out why it's causing the Bluebeach theme to break. Thanks man!

We developed this little beauty of code for one of our clients, so it's a D5 version, but with all the hullabaloo, we felt like we should share with the community....you know, in case you ever get tired of hosting Rick on your website.

Well, clearly this module is not complete until it defines some hooks and an API. Think of all the contrib modules that could be written to extend it!! The man is a lyrical genius, and hardcoding his work into only SOME parts of core -- with no option for contrib modules to add it in other places -- is certainly the wrong approach ;)

I tested it and it works great ...

The patch removes the stray __MACOSX (sorry to Apple fanbois), fixes all code style issues, and makes the patch in proper tar.gz format.

Screenshots are attached.

I am RTBC'ing my own patch, but it is a good occasion to do so ...

@csevb10

Why is the code so different from the D6 version? This will make patching from one version to the other very difficult.

-1 until they are from the same code base, only different D5 and D6 APIs.

sweet! just what i've been missing in my life - more rickroll!

Patch applied to HEAD. Still needs to be ported to Drupal 6.

Gotta love internet meme's. Props though, at least some of us have a sense of humor.

I'm actually concerned about the scalability of this change. Has anyone tested the Rickrolling concurrency levels we can expect to achieve? I mean, we don't want to bring down the site, even if Rick does bring down the house with it.

David

The module only works with PostgreSQL, so we can let the 5% of Drupal sites worry about it.

Moreover, there are no open socket connections server side. The suckers browsing to the /rickroll page will have the connection from their browser to Youtube directly

@kbahey We can probably throttle traffic using this transport layer: http://www.ietf.org/rfc/rfc1149.txt

Doh! [smacks head] That's right, it's April 1 over on that side of the world. I'm used to ignoring Drupal timestamps because they're always wrong by an hour or by GMT offset or by a day or 3 weeks or whatever.

I just wanna tell you how I'm feeling
Gotta make you understand

Rick Astley started out as a tea boy in the studios of Stock, Aitken and Waterman.

It just goes to show, with a bit of grit and determination, and a lot of hard work, you could be pouring a cup of tea one minute, and the next, some idiot bastard producer has made you into a one hit wonder. Thanks, Mr Waterman.

Thanks, Mr Waterman.

Is that the 'write the theme tune, sing the theme tune' Mr Waterman?

Right people right time,
Just the wrong location,
I've got a good idea,
Just you keep me near,
I'll be so good for Drupalcoredevelopment!

Hi,

I miss the audio hooks in the patch.
Seeing is Believing, but without hearing the fun is less!
Greetings,
Martijn
www.trekking-world.com

@David Strauss

Throttling the traffic will make it worse. Each Apache process will take longer to complete, and soon we overshoot MaxClients.

Anyway, we missed the window of having this in core properly yesterday.

So, @Skiquel, my plan would be to do this:

- Create a contrib project for it, commit the code, have a 5.x and 6.x version. Contrib is the incubator for innovation, and hence having it there would allow it to get more exposure, more features, and patches without having the high bar set for core.

- Create an install profile for it, so it is ready this time next year.

- Push for Acquia to create a Drupal distribution for it.

Very funny, FF should have a rickroll page amongst it's hidden pages.

Getting this one out of the critical issues list. Good job on a great prank, everybody.
______________________________
Senpai (also see my Drupal Dojo account)