Menu Trim level install
DynV - April 1, 2008 - 07:10
| Project: | Menu Trim |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Jump to:
Description
There was no install before so I made a patch from an empty file. It will need to be patched as it don't create the menu_trim table yet. It contains an update for the previous version data management.
| Attachment | Size |
|---|---|
| install_orig.patch | 4.94 KB |
#1
A workaround for now on a fresh install (not updating) is to simply create a
menu_trimtable in the Drupal DB.#2
The install code for a new table should go in the same patch that needs that table. Otherwise, committing this patch alone would just add a useless table...
If you need this table at some point, please explain the reasons in the issue that needs it.
Please avoid commenting closing braces... That's the kind of documentation that does not help much and that can easily get accidentally wrong.
The error checking code seems overkill. I've never seen anything like that in any Drupal module.
#3
Oh ! The new table comment is giving me more idea about the patch integration concept (commit).
This was a preleminary version and I personally prefer closing braces comment, I will change it for the working versions.
I think you're right about the error checking but don't you think it's interesting ? Or shoud I simply remove it ?