This patch cleans up mostly whitespace and updates some uses of db_query() with LIMIT to db_query_range().

Please test.

CommentFileSizeAuthor
#7 241288_token_coding_standards_5x.patch15 KBgreggles
#6 241288_token_coding_standards_6.patch15.33 KBgreggles
#2 241288_token_code_cleanup.patch14.48 KBgreggles
#1 token_241288.patch6.3 KBdrewish
token-coding-standards-SP20080401-unified.patch6.71 KBsamirnassar

Comments

drewish’s picture

drewish commented
StatusFileSize
new token_241288.patch6.3 KB

fixed one hunk that didn't apply correctly.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Priority: Normal » Critical
StatusFileSize
new 241288_token_code_cleanup.patch14.48 KB

Ok, I marked #250634: Code style cleanup as a duplicate since this is newer older. And as I said there, I would like to get this fixed and will make it the priority patch for token (i.e. nothing else gets fixed until this one).

So, attached is an updated patch for 6.x. Any reviews? Thanks.

samirnassar’s picture

samirnassar commented

Patch applies cleanly.
Module activated without problems.

samirnassar’s picture

samirnassar commented

I ran the patched token against coder and I am happy to report 10 fingers and 10 toes.

mustafau’s picture

mustafau commented
Status: Needs review » Needs work

Coder gives following warning on token_actions.module

 * @file block missing

and following on token.module

Line 9: There should be no trailing spaces

 * Tokens are small bits of text that can be placed into larger documents
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 241288_token_coding_standards_6.patch15.33 KB

Okey doke. Thanks for those catches.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new 241288_token_coding_standards_5x.patch15 KB

And here's one for 5.x

These seem ready to go to me. Any last nits to pick?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

Fixed in 6.x and 5.x.

Thanks steamedpenguin, Gabor Hojtsy, drewish, and mustafau!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.