Find updated Flash Gallery module for Drupal 6. Please, review the code and create a new branch and a package.
Thank you.

Comments

sime’s picture

Project: SWF Tools » Flash gallery
Component: Flash Gallery » Code

** Moving Flash Gallery issues to own queue **

sime’s picture

Thanks Jan

Commited to D6
http://drupal.org/cvs?commit=108712
http://drupal.org/node/241572 (release which will be hidden until packaged)

Please note that I am looking for a new maintainer for Flash Gallery, and I personally won't make any official releases. Comment here if you're interested.

Cheers
Simon

yngens’s picture

info file is missing and also after activating it gives:

Fatal error: Call to undefined function theme_add_style() in modules/flash_gallery/flash_gallery.module on line 16

sime’s picture

Status: Needs review » Active

added info file.

please add a patch for fixing that function if you like.

thomas23@drupal.org’s picture

subscribing, since I'm interested to know when there is a release. The tar ball you linked wouldn't even let me activate that module. In drupals modules list is says:

6.x-1.x-dev Provides Flash player integration with your image galleries. Initially
This version is incompatible with the 6.2 version of Drupal core.

And it doesn't show the modules name, neither (info file?).

Cheers.

Vially’s picture

I would also love to see Flash Gallery ported to Drupal 6 and forth, but it seems we're out of luck. There is even one guy offering 400$ for this job, but still no one knows how to do it. Too bad I don't have any clue about flash...

Anyone know any good alternatives besides Lightbox ?

carlcasca’s picture

There's a post at

http://www.christianloza.com/howToDrupalSimpleviewer

but I couldn't get it to work under drupal6. It is really a shame that drupal 6 can't work with flash galleries (simpleviewer in particular). I'm kind of a newbie w/ drupal. Would I be giving up a lot to just downgrade to drupal 5
on a fairly simple site?

Frank_F2’s picture

I changed to Piclens (http://drupal.org/project/piclens), although this module isn't as minimalistic as flashgallery...

Vially’s picture

I would say that running an important site is still easier on Drupal 5 then 6, because the modules haven't matured enough on v6 to be able to use them as easy as those for Drupal 5. So the answer is no, you will not lose anything important by downgrading, au contraire. This is my opinion, at least.

However, one should always look forward for the future, and there is none for this module, at least until now. Hopefully we'll find an alternative, or someone kind and knowledgeable enough to take this module further...

nextpulse’s picture

Category: task » support
Status: Needs review » Active
lilou’s picture

Category: support » task
Status: Active » Needs review
ls6pilot’s picture

Category: support » task
Status: Active » Needs review
StatusFileSize
new226 bytes

Here's an info file that works with Drupal 6.x

wilgrace’s picture

Did anyone manage to get this to work? The latest info file is working (thanks ls6pilot) but I'm getting this error:
Missing argument 1 for flash_gallery_menu() in ... on line 15.

This is breaking the site, so clearly not quite there yet. Is anyone maintaining this module? I'd really appreciate the 6 update as it's a great piece of functionality.

thanks
wil

iNade’s picture

Subscribing.

slip’s picture

StatusFileSize
new11.58 KB

Here's a working D6 version of the current stable D5 version. I looked at the current dev code and it didn't look right. I'm not sure if the code above works.. I redid it and my version's working well. I'm going to be using it on a site so I'll post new versions if I find bugs. I'm also offering to maintain this project.

slip’s picture

StatusFileSize
new11.66 KB

quick fix. Sorry about the the extra underscores and what not in tar_.gz extension. Just rename it first I guess.

iNade’s picture

Nice, I give it a try.

Seem's to have a little bug : can't build thumbnail library in Flash Galleries settings.

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT n.nid FROM term_node t INNER JOIN node n ON t.nid = n.nid WHERE n.status = 1 AND n.type='image' AND t.tid IN () in ***\sites\all\Modules\flash_gallery\flash_gallery.module on line 370.

Any idea ?

slip’s picture

It appears that you haven't created an image gallery. Create one and see if it works.

Please confirm and I will add a message to the code when this happens.

Thanks!

iNade’s picture

It appears that you haven't created an image gallery. Create one and see if it works.

Yes, that's it ! It's working. :)

I've installed the simpleviewer and now, the flash is display...

Hovewer :

- Taxonomy problem : when i try to create a new image via CCK, I can't choose between one taxonomy (=gallery) or another. When I had only one gallery created (so only one taxonomy), there was a field to choose which taxonomy i wanted to give to my image. So now i can't add an image to any gallery. Fixed

- Flash display problem : I have the simpleviewer in mysite/fgallery/1 but nothing appears : no thumb or whatever.

Thanks again for your support.

slip’s picture

Charly75,

are you uploading your image through /node/add/image ??? Try using that. You should see a select box labeled 'Image Galleries'

iNade’s picture

Yes, I am.

I fixed the problem going to Taxonomy and... manually check the box to display the field using certain kind of content.

Do you have any idea for the second problem (flash one) ?

Moreover, when I display the fgallery, I have this bug.

Take a look at that : http://img78.imageshack.us/img78/807/exemple.png

slip’s picture

I don't think you're uploading your image correctly. You must do it through /node/add/image

slip’s picture

StatusFileSize
new11.65 KB

Charly75 and I got his copy running then we discovers a bug or two. His is working nicely now.

Here's the latest copy.

iNade’s picture

Thank's a bunch to slip for this really good work.

Important notice : user can only upload jpeg yet.

If you're new with simpleviewer, don't forget to dowload the files from the simpleviewer website, and read INSTALL.txt in the module folder !

Works like a charm. Big up for slip !

abaddon’s picture

you might be interested in this approach as well: http://drupal.org/node/505568 (simpleviewer + image gallery for D6, although this issue states that it is for D5..)

it takes over the default image gallery display and reroutes through simpleviewer, i did start with looking through flash_gallery but i didnt liked how it duplicated code from image_gallery, my approach i think duplicates much less and as a goal for the future would be to duplicate none and have some better hooks into image gallery.. also at the time i started coding this there wasnt a working D6 version
feel free to leave comments of any kind, im also a newb in drupal so i would appreciate the constructive critic, and i know my code doesnt adhere to the coding styles of drupal, if there will be enough interest in my code ill adapt it :-)

danieltome’s picture

StatusFileSize
new36.39 KB

I had already created a drupal 6.x port. I hadn't seen this thread before.
Anyway, here is my version.
I'm willing to maintain it.

I've ran it through coder and it passes ok.

Sime, can you acknowledge it's ok that I maintain it?

danieltome’s picture

StatusFileSize
new36.37 KB

Ok.. I've updated some code and fixed the thumbnail rebuild.

sime’s picture

I acknowledge that danieltome will be the new maintainer of this module.

Great work danieltome!

avpaderno’s picture

@sime: Do you meant to pass him the ownership of the module?

danieltome has now access to the project repository, but he is a co-maintainer.

Marco Palmero’s picture

Thanks guys for the 6.x port... just wondering... if I install this as I upgrade my 5.x to 6.x would it work? Would it pass on the previous values or do I need to start from scratch?

Marco Palmero’s picture

Ok I went ahead and did the upgrade anyway.

I have a problem though... When I installed it, the gallery only seems to work in Internet Explorer, but not in Firefox...

I've installed Adobe flash, restarted and still doesn't work...

Thanks danieltome for the port...

Marco Palmero’s picture

hmm... found a "solution" for my "problem" above. I just used my old simpleviewer files and it worked.

I also checked on browsershots.org that the new module here works with less browsers... may want to use an older version of simpleviewer...

danieltome’s picture

thanks marcopolo that was strange. I've tested in Firefox and Safari on Mac.
What firefox version and flash player version do you have?

Marco Palmero’s picture

Yeah indeed it is strange. I have a PC. I ended up using v1.4.1. Latest Firefox version and Adobe Flash. I even updated them to make sure.

Also, when I tested on browsershots.org I found that it didn't work on about 50% of all screenshots. And when I reverted back it worked on maybe 90%...

the_opus’s picture

Version: 5.x-1.1 » 6.x-1.0
Category: task » feature

Hi Daniel,

Thanks a bunch for taking this module to the v6 level!

I noticed that the latest release of Simpleviewer 2 is out and it doesn't work with the module (either v5 or v6). I think it has something to do with the new SWFObject.

What happens is that the page loads with a Flash not found error. (it has to do with how the module calls the swfobject constructor function I think)

When I replace the new simpleviewer with the older version, it works fine.

Thanks,
Owen

danieltome’s picture

Thanks the_opus,

I will look at making it work for both versions.

cheers,

avpaderno’s picture

Version: 6.x-1.0 » 6.x-1.x-dev
Issue summary: View changes
Status: Needs review » Closed (outdated)

I am closing this issue, which is for a Drupal version that isn't supported.