Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I experienced two problem with the "page does not exist" page (patch attached which fixes these):
(1) The "creation form" would not show up if the node type contained an underscore (ie. "_").
This is because it was making a URL like "node/add/node_type" where underscore always become dashes here (per the node module) and it should instead be "node/add/node-type".
(2) No matter what settings were saved on the admin form for "Wiki 404 type", all three were always shown.
This was caused by theme_wikitools_page_does_not_exist() using isset() on the return value of wikitools_404(). This would work if the admin form was never saved and the variable default was returned. But once the form was saved, it will be set for every possible value (per the form api) with selected options having a value of their title and the unselected a value of 0.
Please let me know if any changes to my patch are necessary for acceptance! Thank you.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | wikitools6-404.diff | 1.27 KB | dsnopek |
| wikitools6-404.diff | 1.27 KB | dsnopek |
Comments
Comment #1
dsnopekAck! I just caught a coding standards problem with my patch. Trusty coder module. ;-)
Attached is a version with correct spacing around the string concat operator.
Comment #2
cwgordon7 commentedThank you for your patch! The first part was committed as part of another patch, but the second part was good, and was committed, thanks! Sorry it took so long.