¿Can you put links in "Successfully pingbacked URLs" and not only the url?

CommentFileSizeAuthor
#5 _pingback.activelink.patch1_.txt555 bytesjonathan1055
#4 _pingback.activelink.patch.txt586 bytesjonathan1055
#2 pingbacks.png40.82 KBcarlitus

Comments

andreashaugstrup’s picture

andreashaugstrup commented

I don't understand. The "[URL] pingbacked successfully" message does contain a link. Just click on the URL and you're taken to the URL the pingback was sent to.

carlitus’s picture

carlitus commented
StatusFileSize
new pingbacks.png40.82 KB

In the form edit node there are a fieldset called "Pingbacks" Inside this fieldset there are a list of "Successfully pingbacked URLs". The problem is that there is a plain list of url and not an anchor list.

I have the last pingback (6.10).

andreashaugstrup’s picture

andreashaugstrup commented
Assigned: Unassigned » andreashaugstrup

I understand what you're talking about now. I'll make a patch shortly.

jonathan1055’s picture

jonathan1055 commented
Title: links in "Successfully pingbacked URLs" » Make links active in "Successfully pingbacked URLs"
Status: Active » Needs review
StatusFileSize
new _pingback.activelink.patch.txt586 bytes

This is a good idea. In pingback_form_alter() I changed

        $past_successes_listing[] = $pb->url;

into

        $past_successes_listing[] = l($pb->url,$pb->url);

Attached is a patch which you can use to do this.

Jonathan

jonathan1055’s picture

jonathan1055 commented
StatusFileSize
new _pingback.activelink.patch1_.txt555 bytes

Sorry, the patch file above had my own // JSS. comment (which I use to find my own changes in contrib modules). I should have removed this before I rolled the patch. Here is is again

[interestingly, I was able to edit the previous comment, but not delete and re-add the attachment, which is why I had to add this new comment]

andreashaugstrup’s picture

andreashaugstrup commented
Status: Needs review » Fixed

And this went into HEAD also. Thank you. :o)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.