Remove an unnecessary setting in upload module [#24183]

Comment	File	Size	Author
#10	upload.module_8.diff	6.57 KB	drumm
#8	upload.module_7.diff	4.75 KB	drumm
#6	upload.module_6.diff	3.94 KB	drumm
	upload.module_5.diff	4.01 KB	drumm

Comment #1

he/him

NY, US

commented 2 June 2005 at 18:15

Oh and this includes a refactoring which changes one undocumented function that did two things into two documented functions that do one thing each. Forgot about that part.

Log in or register to post comments

Well, you're not entirely correct... upload module allows you to disable a limit by setting it to 0. Thus, you could either want per-role settings, or global settings. Or use the global setting for everyone, except have one role have a stricter limit.

So we need to decide whether these are valid use cases, or just unnecessary complexity.

Log in or register to post comments

Comment #3

Bèr Kessels commented 2 June 2005 at 19:21

I add a +1 for anything that removes complexity from the upload module. So I +1 this change.

Log in or register to post comments

Comment #4

dries commented 3 June 2005 at 11:58

Removing the global check is OK if we remove the '0 is unlimited'-paradigm. A paradigm which, by the way, is developer-centric. I don't mind us removing it.

Log in or register to post comments

Comment #5

drumm

he/him

NY, US

commented 7 June 2005 at 05:34

This revised patch should make '0' or blank mean unlimited for the per user quota and file size limits. I have not tested it. It is not documented in the form items. Now might be a good time to look at the defualts for those. I still very short on time and probably won't be able to properly revisit this for a week or so. Got to get on a plane now.