Closed (fixed)
Project:
Printer, email and PDF versions
Version:
5.x-3.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
2 Apr 2008 at 16:00 UTC
Updated:
23 Apr 2008 at 07:57 UTC
Comments
Comment #1
jcnventuraHi,
Of course that you can do whatever you want with the code. However, after having seen the Thickbox module demonstration, it seems that it is very similar to the greybox module.
If you download the dev version of the print module and the greybox module, you will be able to configure the 'open in a new window' feature of the print module to use the greybox code. It was actually so simply to enable support for the greybox module: I just had to add a class='greybox' to the href tag of the printer-friendly page link. From the demo site, I think that to enable support for the thickbox module would also be a case of adding class='thickbox' to it. Since I have already added greybox support, I see no problem in adding tickbox support also (but if this keeps growing, I may simply enable the use of a user-defined class name).
If you install print, but disable the links, the print/node pages will still be available, so I don't think you need to modify print for that.
As to the your CHANGING THE MODULE.. Well, you're not really changing it. The tpl.php is there to be modded. As long as you don't need the 'real' function of the print module, your current use of it is perfect. If on the other side, you do need the real functionality, then some code must be inserted in the tpl.php to distinguish between the two (I have no idea how).
I would advise against creating a knockoff, as this would lead to someone having to synchronize the code from time to time.
João
Comment #2
jcnventuraHi,
I have enabled support for the thickbox module in the dev versions of the module. Enable it via the 'Settings' pane of the print module. Can you try to see if that's enough for your needs?
João
Comment #3
taliesinangelus commentedAs an aside, I see the Thickbox module listed for only 5.x implementations. You can run it in 6.x?
Comment #4
jcnventuraNo.
And greybox is also not (yet) supported in 6.x). But when they are, they will be supported by those settings. Except for the PDF part, which I am not adding to the 5.x because there are already modules for that, I am trying to keep 5.x and 6.x in sync.
What I am planning, though is to change the way support for greybox and thickbox is being done. Instead of a simple radio button, I will add a text field for users to select their favourite jQuery class. This would add support to greybox, thickbox and all other boxes out there.
João
Comment #5
johnvsc commentedThanks for the reply.
Yeah, creating a knockoff was the last option. I would rather add to the functionality of a current module than create something so close.
Ok, I will look at your suggestion above and see if I can duplicate it / add on to it. I will try it with Greybox and see if I can get it to work.
Will let you know how it goes!
ps, GREAT module!!!!
Comment #6
jcnventuraNo further info received in the last two weeks... Closing the issue.